blimp/net/client_connection_manager_unittest.cc - Issue 1876983002: Use Chromium BUILD to approximate Blimp protocol version, and check it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/client_connection_manager_unittest.cc

Issue 1876983002: Use Chromium BUILD to approximate Blimp protocol version, and check it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add disconnection message and unit-tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/common/proto/protocol_control.proto ('K') | « blimp/net/client_connection_manager.cc ('k') | blimp/net/engine_authentication_handler.cc » ('j') | blimp/net/engine_authentication_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/net/client_connection_manager_unittest.cc

diff --git a/blimp/net/client_connection_manager_unittest.cc b/blimp/net/client_connection_manager_unittest.cc

index fd128e1de2a58741f4786c041ecaa541c3497529..e5b4e4de03d30eb39fe09795b4fb0ddfce69703c 100644

--- a/blimp/net/client_connection_manager_unittest.cc

+++ b/blimp/net/client_connection_manager_unittest.cc

@@ -13,7 +13,7 @@

#include "base/message_loop/message_loop.h"

#include "blimp/common/create_blimp_message.h"

#include "blimp/common/proto/blimp_message.pb.h"

-#include "blimp/common/protocol_version.h"

+#include "blimp/common/version_info.h"

#include "blimp/net/blimp_connection.h"

#include "blimp/net/blimp_transport.h"

#include "blimp/net/test_common.h"

@@ -44,7 +44,8 @@ class ClientConnectionManagerTest : public testing::Test {

connection_(new BlimpConnection(base::WrapUnique(reader_),

base::WrapUnique(writer_))),

start_connection_message_(

- CreateStartConnectionMessage(kDummyClientToken, kProtocolVersion)) {

+ CreateStartConnectionMessage(kDummyClientToken,

+ GetProtocolVersion())) {

manager_->set_client_token(kDummyClientToken);

}