Use Chromium BUILD to approximate Blimp protocol version, and check it.

blimp/net/blimp_connection_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/net/blimp_connection.h"
 
 #include <stddef.h>
 
 #include <string>
 
@@ skipping 19 matching lines @@
 
 namespace blimp {
 namespace {
 
 class BlimpConnectionTest : public testing::Test {
  public:
   BlimpConnectionTest() {
     std::unique_ptr<testing::StrictMock<MockPacketWriter>> writer(
         new testing::StrictMock<MockPacketWriter>);
     writer_ = writer.get();
+    std::unique_ptr<testing::StrictMock<MockPacketWriter>> reader(
+        new testing::StrictMock<MockPacketWriter>);
     connection_.reset(new BlimpConnection(
         base::WrapUnique(new MockPacketReader), std::move(writer)));
     connection_->AddConnectionErrorObserver(&error_observer1_);
     connection_->AddConnectionErrorObserver(&error_observer2_);
     connection_->AddConnectionErrorObserver(&error_observer3_);
     connection_->RemoveConnectionErrorObserver(&error_observer3_);
   }
 
   ~BlimpConnectionTest() override {}
 
@@ skipping 27 matching lines @@
 
   InSequence s;
   EXPECT_CALL(*writer_,
               WritePacket(BufferEqualsProto(*CreateInputMessage()), _))
       .WillOnce(SaveArg<1>(&write_packet_cb))
       .RetiresOnSaturation();
   EXPECT_CALL(*writer_,
               WritePacket(BufferEqualsProto(*CreateControlMessage()), _))
       .WillOnce(SaveArg<1>(&write_packet_cb))
       .RetiresOnSaturation();
+  EXPECT_CALL(error_observer1_, OnConnectionError(_)).Times(0);
+  EXPECT_CALL(error_observer2_, OnConnectionError(_)).Times(0);
+  EXPECT_CALL(error_observer3_, OnConnectionError(_)).Times(0);
 
   BlimpMessageProcessor* sender = connection_->GetOutgoingMessageProcessor();
   net::TestCompletionCallback complete_cb_1;
   ASSERT_TRUE(write_packet_cb.is_null());
   sender->ProcessMessage(CreateInputMessage(),
                          complete_cb_1.callback());
   ASSERT_FALSE(write_packet_cb.is_null());
   base::ResetAndReturn(&write_packet_cb).Run(net::OK);
   EXPECT_EQ(net::OK, complete_cb_1.WaitForResult());
 
@@ skipping 15 matching lines @@
   EXPECT_CALL(*writer_,
               WritePacket(BufferEqualsProto(*CreateInputMessage()), _))
       .WillOnce(SaveArg<1>(&write_packet_cb))
       .RetiresOnSaturation();
   EXPECT_CALL(*writer_,
               WritePacket(BufferEqualsProto(*CreateControlMessage()), _))
       .WillOnce(SaveArg<1>(&write_packet_cb))
       .RetiresOnSaturation();
   EXPECT_CALL(error_observer1_, OnConnectionError(net::ERR_FAILED));
   EXPECT_CALL(error_observer2_, OnConnectionError(net::ERR_FAILED));
+  EXPECT_CALL(error_observer3_, OnConnectionError(_)).Times(0);
 
   BlimpMessageProcessor* sender = connection_->GetOutgoingMessageProcessor();
   net::TestCompletionCallback complete_cb_1;
   sender->ProcessMessage(CreateInputMessage(),
                          complete_cb_1.callback());
   base::ResetAndReturn(&write_packet_cb).Run(net::OK);
   EXPECT_EQ(net::OK, complete_cb_1.WaitForResult());
 
   net::TestCompletionCallback complete_cb_2;
   sender->ProcessMessage(CreateControlMessage(),
                          complete_cb_2.callback());
   base::ResetAndReturn(&write_packet_cb).Run(net::ERR_FAILED);
   EXPECT_EQ(net::ERR_FAILED, complete_cb_2.WaitForResult());
 }
 
+// Verifies that EndConnection messages received from the peer are
+// routed through to registered ConnectionErrorObservers as errors.
+TEST_F(BlimpConnectionTest, EndConnectionInvokesErrorObservers) {
+  // XXX test of how EndConnection messages are processed goes here.

[Kevin M, 2016/05/25 21:19:19]

Is this a TODO for this CL or for a followup? If it's the latter, can you put
them into TODO(wez)'s?

[Wez, 2016/05/25 23:11:37]

TODO for this CL; wanted to get your input on whether to put the EndConnection
handler in BlimpConnection, versus BrowserConnectionHandler, before spending
time writing tests.

+  // XXX we should also have a test that we invoke error observers on read
+  // failures!
+}
+
 }  // namespace
 }  // namespace blimp