blimp/common/version_info.h - Issue 1876983002: Use Chromium BUILD to approximate Blimp protocol version, and check it.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/version_info.h

Issue 1876983002: Use Chromium BUILD to approximate Blimp protocol version, and check it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Route EndConnection to OnConnectionError notifications Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BLIMP_COMMON_VERSION_INFO_H_

	6 #define BLIMP_COMMON_VERSION_INFO_H_

	7

	8 #include <string>

	9

	10 #include "blimp/common/blimp_common_export.h"

	11

	12 namespace blimp {

	13

	14 // Latest version of the protocol supported by this build.

	15 int BLIMP_COMMON_EXPORT GetProtocolVersion();

	16

	17 // String containing the MAJOR.MINOR.BUILD.PATCH version of this build.

	18 std::string BLIMP_COMMON_EXPORT GetBuildVersion();
	Kevin M 2016/05/25 21:19:19 Return a const char? Return a const char? Wez 2016/05/25 23:11:36 I followed the style of version_info::GetVersionNu Show quoted text On 2016/05/25 21:19:19, Kevin M wrote: > Return a const char? I followed the style of version_info::GetVersionNumber() and friends, which all return std::string. But yeah, changed to const char here.
	19

	20 } // namespace blimp

	21

	22 #endif // BLIMP_COMMON_VERSION_INFO_H_

OLD	NEW

« blimp/common/BUILD.gn ('K') | « blimp/common/protocol_version.h ('k') | blimp/common/version_info.cc.version » ('j') | blimp/net/blimp_connection.cc » ('J')