Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1876973002: Reland of [compiler] Make feedback vector cope with flag changes. (Closed)

Created:
4 years, 8 months ago by Michael Hablich
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1876103002/ ) Reason for revert: Did not fail on another roll including this CL .. Original issue's description: > Revert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ ) > > Reason for revert: > Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001 > > Original issue's description: > > [compiler] Make feedback vector cope with flag changes. > > > > This fixes corner cases where the layout of feedback vectors baked into > > the snapshot is different from the expected layout, depending on some > > runtime flags. We make sure the feedback vector is regenereated for > > functions that are not compiled. Flag changes of this kind are only > > allowed when code is not serialized. > > > > An alternative solution would be to not serialize the feedback vector > > for such cases in the first place. That solution however would have a > > higher overhead, as it would required the serializer to be able to > > recognize feedback vectors while generating a snapshot. > > > > R=mvstanton@chromium.org > > TEST=mjsunit/regress/regress-crbug-600995 > > BUG=chromium:600995 > > LOG=n > > > > Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c > > Cr-Commit-Position: refs/heads/master@{#35339} > > TBR=mvstanton@chromium.org,mstarzinger@chromium.org > > BUG=chromium:600995 > LOG=N > NOTRY=true > > Committed: https://crrev.com/78049e9c4837f053575d6c71e53ae12fec99f1aa > Cr-Commit-Position: refs/heads/master@{#35392} TBR=mvstanton@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:600995 Committed: https://crrev.com/b88d048adf051059efb0ac22da191dba359e3fa4 Cr-Commit-Position: refs/heads/master@{#35398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M src/compiler.cc View 1 chunk +5 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-600995.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Hablich
Created Reland of [compiler] Make feedback vector cope with flag changes.
4 years, 8 months ago (2016-04-11 18:56:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876973002/1
4 years, 8 months ago (2016-04-11 18:56:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 18:56:32 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 18:56:51 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b88d048adf051059efb0ac22da191dba359e3fa4
Cr-Commit-Position: refs/heads/master@{#35398}

Powered by Google App Engine
This is Rietveld 408576698