Small refactor git cl py.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld and Gerrit."""
 
 from distutils.version import LooseVersion
@@ skipping 1433 matching lines @@
   def FetchDescription(self):
     """Fetches and returns description from the codereview server."""
     raise NotImplementedError()
 
   def GetCodereviewServerSetting(self):
     """Returns git config setting for the codereview server."""
     raise NotImplementedError()
 
   @classmethod
   def IssueSetting(cls, branch):
-    return 'branch.%s.%s' % (branch, cls.IssueSettingPrefix())
+    return 'branch.%s.%s' % (branch, cls.IssueSettingSuffix())
 
   @classmethod
-  def IssueSettingPrefix(cls):
+  def IssueSettingSuffix(cls):
     """Returns name of git config setting which stores issue number for a given
     branch."""
     raise NotImplementedError()
 
   def PatchsetSetting(self):
     """Returns name of git config setting which stores issue number."""
     raise NotImplementedError()
 
   def GetRieveldObjForPresubmit(self):
     # This is an unfortunate Rietveld-embeddedness in presubmit.
@@ skipping 200 matching lines @@
   def RpcServer(self):
     """Returns an upload.RpcServer() to access this review's rietveld instance.
     """
     if not self._rpc_server:
       self._rpc_server = rietveld.CachingRietveld(
           self.GetCodereviewServer(),
           self._auth_config or auth.make_auth_config())
     return self._rpc_server
 
   @classmethod
-  def IssueSettingPrefix(cls):
+  def IssueSettingSuffix(cls):
     return 'rietveldissue'
 
   def PatchsetSetting(self):
     """Return the git setting that stores this change's most recent patchset."""
     return 'branch.%s.rietveldpatchset' % self.GetBranch()
 
   def GetCodereviewServerSetting(self):
     """Returns the git setting that stores this change's rietveld server."""
     branch = self.GetBranch()
     if branch:
@@ skipping 272 matching lines @@
       if not self._gerrit_server:
         # We assume repo to be hosted on Gerrit, and hence Gerrit server
         # has "-review" suffix for lowest level subdomain.
         parts = urlparse.urlparse(self.GetRemoteUrl()).netloc.split('.')
         parts[0] = parts[0] + '-review'
         self._gerrit_host = '.'.join(parts)
         self._gerrit_server = 'https://%s' % self._gerrit_host
     return self._gerrit_server
 
   @classmethod
-  def IssueSettingPrefix(cls):
+  def IssueSettingSuffix(cls):
     return 'gerritissue'
 
   def EnsureAuthenticated(self):
     """Best effort check that user is authenticated with Gerrit server."""
     #TODO(tandrii): implement and close the corresponding bug.
 
   def PatchsetSetting(self):
     """Return the git setting that stores this change's most recent patchset."""
     return 'branch.%s.gerritpatchset' % self.GetBranch()
 
@@ skipping 2587 matching lines @@
   def find_issues(issueprefix):
     key_and_issues = [x.split() for x in RunGit(
         ['config', '--local', '--get-regexp', r'branch\..*\.%s' % issueprefix])
         .splitlines()]
     for key, issue in key_and_issues:
       if issue == target_issue:
         yield re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key)
 
   branches = []
   for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
-    branches.extend(find_issues(cls.IssueSettingPrefix()))
+    branches.extend(find_issues(cls.IssueSettingSuffix()))
   if len(branches) == 0:
     print 'No branch found for issue %s.' % target_issue
     return 1
   if len(branches) == 1:
     RunGit(['checkout', branches[0]])
   else:
     print 'Multiple branches match issue %s:' % target_issue
     for i in range(len(branches)):
       print '%d: %s' % (i, branches[i])
     which = raw_input('Choose by index: ')
@@ skipping 61 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   setup_color.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)