Implements TestMessageLoop that flushes pending tasks on destruction.

Implements TestMessageLoop that flushes pending tasks on destruction.

This is intended to be used by unittests that need MessageLoop
without a thread and need to run all posted tasks before exiting
for a clean teardown.

Committed: https://crrev.com/42544a8df04b15f7903481bdaf9a9efd6643d332
Cr-Commit-Position: refs/heads/master@{#386548}

[alokp, 2016-04-11 21:50:26]

alokp@chromium.org changed reviewers:
+ danakj@chromium.org

[alokp, 2016-04-11 21:50:26]

Dana: I plan to use it in this patch https://codereview.chromium.org/1806313003/
to ensure that AudioManager instance, which is destroyed using
TaskRunner::DeleteSoon, is actually destroyed.

[danakj, 2016-04-11 21:56:06]

LGTM

https://codereview.chromium.org/1876903005/diff/20001/base/test/test_message_...
File base/test/test_message_loop.h (right):

https://codereview.chromium.org/1876903005/diff/20001/base/test/test_message_...
base/test/test_message_loop.h:29: #endif  // BASE_TEST_TEST_MESSAGE_LOOP_H_
whitespace above this.

[danakj, 2016-04-11 21:57:02]

On 2016/04/11 21:50:26, alokp wrote:
> Dana: I plan to use it in this patch
https://codereview.chromium.org/1806313003/
> to ensure that AudioManager instance, which is destroyed using
> TaskRunner::DeleteSoon, is actually destroyed.

Maybe we could use this pretty widely, and convert message loops in tests to use
this more. We have a lot of leaky DeleteSoons in tests that it would be nice to
not have. Is it something we could maybe automate somewhat, or find existing
ones to convert easily?

[alokp, 2016-04-11 22:15:26]

Good idea. I can look at the memory suppressions for unittests and convert the
ones that can be fixed by using TestMessageLoop (I will open a bug against
myself).

I will also send an update to my thread on chromium-dev so that developers know
about this class.

https://codereview.chromium.org/1876903005/diff/20001/base/test/test_message_...
File base/test/test_message_loop.h (right):

https://codereview.chromium.org/1876903005/diff/20001/base/test/test_message_...
base/test/test_message_loop.h:29: #endif  // BASE_TEST_TEST_MESSAGE_LOOP_H_
On 2016/04/11 21:56:06, danakj wrote:
> whitespace above this.

Done.

[alokp, 2016-04-11 22:15:48]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-04-11 22:15:49]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1876903005/#ps40001
(title: "added ws")

[commit-bot: I haz the power, 2016-04-11 22:17:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1876903005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1876903005/40001

[commit-bot: I haz the power, 2016-04-12 01:54:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-12 01:55:29]

Description was changed from

==========
Implements TestMessageLoop that flushes pending tasks on destruction.

This is intended to be used by unittests that need MessageLoop
without a thread and need to run all posted tasks before exiting
for a clean teardown.
==========

to

==========
Implements TestMessageLoop that flushes pending tasks on destruction.

This is intended to be used by unittests that need MessageLoop
without a thread and need to run all posted tasks before exiting
for a clean teardown.

Committed: https://crrev.com/42544a8df04b15f7903481bdaf9a9efd6643d332
Cr-Commit-Position: refs/heads/master@{#386548}
==========

[commit-bot: I haz the power, 2016-04-12 01:55:30]

Patchset 3 (id:??) landed as
https://crrev.com/42544a8df04b15f7903481bdaf9a9efd6643d332
Cr-Commit-Position: refs/heads/master@{#386548}