Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 18769009: [Activity Log] fix logging of blocked API calls (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Probably helps to spell things correctly Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/dispatcher.cc
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index 1f80d785f10daff9187da28e7215957bed90f6b6..3a05abc2fcda1221e253256409bb660d5ec08393 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -177,6 +177,8 @@ class V8ContextNativeHandler : public ObjectBackedNativeHandler {
v8::Boolean::New(availability.is_available()));
ret->Set(v8::String::New("message"),
v8::String::New(availability.message().c_str()));
+ ret->Set(v8::String::New("result"),
+ v8::Integer::New(availability.result()));
args.GetReturnValue().Set(ret);
}
@@ -1442,6 +1444,10 @@ bool Dispatcher::CheckContextAccessToExtensionAPI(
Feature::Availability availability = context->GetAvailability(function_name);
if (!availability.is_available()) {
+ Feature::AvailabilityResult result = availability.result();
not at google - send to devlin 2013/07/12 15:53:07 nit: inline?
felt 2013/07/13 04:38:55 Done.
+ APIActivityLogger::LogBlockedCall(context->extension()->id(),
+ function_name,
+ result);
v8::ThrowException(v8::Exception::Error(
v8::String::New(availability.message().c_str())));
}

Powered by Google App Engine
This is Rietveld 408576698