[Activity Log] fix logging of blocked API calls

chrome/renderer/extensions/runtime_custom_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/runtime_custom_bindings.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension.h"
@@ skipping 52 matching lines @@
 }
 
 void RuntimeCustomBindings::OpenChannelToNativeApp(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   // Verify that the extension has permission to use native messaging.
   if (!BaseFeatureProvider::GetByName("permission")->GetFeature(
         "nativeMessaging")->IsAvailableToContext(
             GetExtensionForRenderView(),
             context()->context_type(),
             context()->GetURL()).is_available()) {
+    APIActivityLogger::LogBlockedCall(context()->extension()->id(),
+                                      "nativeMessaging");

[not at google - send to devlin, 2013/07/11 19:22:33]

Ok, maybe we should add a utility to ChromeV8Context to do this automatically,
like IsFeatureAvailable which takes a Feature. Use that for the call from
dispatcher.cc too.

[felt, 2013/07/11 19:26:37]

Sorry, not 100% sure what you mean here -- add a method to Chromev8context that,
in turn, then calls APIActivityLogger::LogBlockedCall?

[not at google - send to devlin, 2013/07/11 19:28:02]

Yep that's what I meant, do the logging in that single place if possible.

[felt, 2013/07/12 01:53:04]

Instead of adding an extra method to be a wrapper around LogBlockedCall, I
changed LogBlockedCall to take in an AvailabilityResult. Does that work for you?

     return;
   }
 
   // Get the current RenderView so that we can send a routed IPC message from
   // the correct source.
   content::RenderView* renderview = GetRenderView();
   if (!renderview)
     return;
 
   // The Javascript code should validate/fill the arguments.
@@ skipping 17 matching lines @@
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   CHECK(context()->extension());
 
   scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
   args.GetReturnValue().Set(
       converter->ToV8Value(context()->extension()->manifest()->value(),
                            context()->v8_context()));
 }
 
 }  // namespace extensions