Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: chrome/renderer/extensions/api_activity_logger.h

Issue 18769009: [Activity Log] fix logging of blocked API calls (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed a logging statement Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_EXTENSIONS_API_ACTIVITY_LOGGER_H_ 5 #ifndef CHROME_RENDERER_EXTENSIONS_API_ACTIVITY_LOGGER_H_
6 #define CHROME_RENDERER_EXTENSIONS_API_ACTIVITY_LOGGER_H_ 6 #define CHROME_RENDERER_EXTENSIONS_API_ACTIVITY_LOGGER_H_
7 7
8 #include <string> 8 #include <string>
9 #include "chrome/renderer/extensions/chrome_v8_extension.h" 9 #include "chrome/renderer/extensions/chrome_v8_extension.h"
10 #include "chrome/renderer/extensions/dispatcher.h" 10 #include "chrome/renderer/extensions/dispatcher.h"
11 #include "v8/include/v8.h" 11 #include "v8/include/v8.h"
12 12
13 namespace extensions { 13 namespace extensions {
14 14
15 // Used to log extension API calls and events that are implemented with custom 15 // Used to log extension API calls and events that are implemented with custom
16 // bindings.The actions are sent via IPC to extensions::ActivityLog for 16 // bindings.The actions are sent via IPC to extensions::ActivityLog for
17 // recording and display. 17 // recording and display.
18 class APIActivityLogger : public ChromeV8Extension { 18 class APIActivityLogger : public ChromeV8Extension {
19 public: 19 public:
20 APIActivityLogger(Dispatcher* dispatcher, ChromeV8Context* context); 20 APIActivityLogger(Dispatcher* dispatcher, ChromeV8Context* context);
21 21
22 // This is ultimately invoked in schema_generated_bindings.js with 22 // This is ultimately invoked in bindings.js with JavaScript arguments.
23 // JavaScript arguments. Logged as an APIAction.
24 // arg0 - extension ID as a string 23 // arg0 - extension ID as a string
25 // arg1 - API call name as a string 24 // arg1 - API call name as a string
26 // arg2 - arguments to the API call 25 // arg2 - arguments to the API call
27 // arg3 - any extra logging info as a string (optional) 26 // arg3 - any extra logging info as a string (optional)
28 static void LogAPICall(const v8::FunctionCallbackInfo<v8::Value>& args); 27 static void LogAPICall(const v8::FunctionCallbackInfo<v8::Value>& args);
29 28
30 // This is ultimately invoked in schema_generated_bindings.js with 29 // This is ultimately invoked in bindings.js with JavaScript arguments.
31 // JavaScript arguments. Logged as an EventAction.
32 // arg0 - extension ID as a string 30 // arg0 - extension ID as a string
33 // arg1 - Event name as a string 31 // arg1 - Event name as a string
34 // arg2 - Event arguments 32 // arg2 - Event arguments
35 // arg3 - any extra logging info as a string (optional) 33 // arg3 - any extra logging info as a string (optional)
36 static void LogEvent(const v8::FunctionCallbackInfo<v8::Value>& args); 34 static void LogEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
37 35
38 // This is for the Dispatcher to use to log blocked API calls. 36 // This is invoked in binding.js with JavaScript arguments.
37 // arg0 - extension ID as string
38 // arg1 - Function name as a string
39 static void LogBlockedCallWrapper(
40 const v8::FunctionCallbackInfo<v8::Value>& args);
41
42 // This is to use to log blocked API calls.
39 static void LogBlockedCall(const std::string& extension_id, 43 static void LogBlockedCall(const std::string& extension_id,
40 const std::string& function_name); 44 const std::string& function_name);
41 45
42 private: 46 private:
43 // Used to distinguish API calls & events from each other in LogInternal. 47 // Used to distinguish API calls & events from each other in LogInternal.
44 enum CallType { 48 enum CallType {
45 APICALL, 49 APICALL,
46 EVENT 50 EVENT
47 }; 51 };
48 52
49 // LogAPICall and LogEvent are really the same underneath except for 53 // LogAPICall and LogEvent are really the same underneath except for
50 // how they are ultimately dispatched to the log. 54 // how they are ultimately dispatched to the log.
51 static void LogInternal(const CallType call_type, 55 static void LogInternal(const CallType call_type,
52 const v8::FunctionCallbackInfo<v8::Value>& args); 56 const v8::FunctionCallbackInfo<v8::Value>& args);
53 57
54 DISALLOW_COPY_AND_ASSIGN(APIActivityLogger); 58 DISALLOW_COPY_AND_ASSIGN(APIActivityLogger);
55 }; 59 };
56 60
57 } // namespace extensions 61 } // namespace extensions
58 62
59 #endif // CHROME_RENDERER_EXTENSIONS_API_ACTIVITY_LOGGER_H_ 63 #endif // CHROME_RENDERER_EXTENSIONS_API_ACTIVITY_LOGGER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/extensions/api_activity_logger.cc » ('j') | chrome/renderer/extensions/api_activity_logger.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698