[Activity Log] fix logging of blocked API calls

chrome/renderer/extensions/api_activity_logger.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include "base/bind.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/renderer/chrome_render_process_observer.h"
 #include "chrome/renderer/extensions/api_activity_logger.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/v8_value_converter.h"
 
 using content::V8ValueConverter;
 
 namespace extensions {
 
 APIActivityLogger::APIActivityLogger(
     Dispatcher* dispatcher, ChromeV8Context* context)
     : ChromeV8Extension(dispatcher, context) {
   RouteFunction("LogEvent", base::Bind(&APIActivityLogger::LogEvent));
   RouteFunction("LogAPICall", base::Bind(&APIActivityLogger::LogAPICall));
+  RouteFunction("LogBlockedCall",
+                base::Bind(&APIActivityLogger::LogBlockedCallWrapper));
 }
 
 // static
 void APIActivityLogger::LogAPICall(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   LogInternal(APICALL, args);
 }
 
 // static
 void APIActivityLogger::LogEvent(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   LogInternal(EVENT, args);
 }
 
 // static
+void APIActivityLogger::LogBlockedCallWrapper(
+    const v8::FunctionCallbackInfo<v8::Value>& args) {
+  DCHECK_EQ(args.Length(), 2);
+  DCHECK(args[0]->IsString());
+  DCHECK(args[1]->IsString());
+  LogBlockedCall(*v8::String::AsciiValue(args[0]->ToString()),
+                 *v8::String::AsciiValue(args[1]->ToString()));

[not at google - send to devlin, 2013/07/11 19:22:33]

you actually don't need the ToString() here. AsciiValue will do that
automatically.

[felt, 2013/07/12 01:53:04]

Done.

+}
+
+// static
 void APIActivityLogger::LogInternal(
     const CallType call_type,
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   DCHECK_GT(args.Length(), 2);
   DCHECK(args[0]->IsString());
   DCHECK(args[1]->IsString());
   DCHECK(args[2]->IsArray());
 
   std::string ext_id = *v8::String::AsciiValue(args[0]->ToString());
   ExtensionHostMsg_APIActionOrEvent_Params params;
@@ skipping 28 matching lines @@
 // static
 void APIActivityLogger::LogBlockedCall(const std::string& extension_id,
                                        const std::string& function_name) {
   content::RenderThread::Get()->Send(
       new ExtensionHostMsg_AddBlockedCallToActivityLog(extension_id,
                                                        function_name));
 }
 
 
 }  // namespace extensions