Issue 18769005: Allow parameterless typed array constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18769005: Allow parameterless typed array constructors. (Closed)

Created:
7 years, 5 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 5 months ago

Reviewers:
Benedikt Meurer, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Allow parameterless typed array constructors. ES6 spec tacitly allows them, and they are allowed in Firefox and in WebKit/Blink. Change committed as https://code.google.com/p/v8/source/detail?r=15579. R=bmeurer@chromium.org,rossberg@chromium.org

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -7 lines)			Patch
M	src/messages.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/typedarray.js	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	test/mjsunit/harmony/typedarrays.js	View	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

7 years, 5 months ago (2013-07-10 09:19:30 UTC) #3

Message was sent while issue was closed.

On 2013/07/09 18:04:39, Benedikt Meurer wrote:
> lgtm

Committed as https://code.google.com/p/v8/source/detail?r=15579.
Not sure why 'git cl dcommit' failed to post here.

Expand Messages | Collapse Messages