Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: src/objects.cc

Issue 18769003: Remove bogus assertion in parallel recompilation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 9157 matching lines...) Expand 10 before | Expand all | Expand 10 after
9168 } 9168 }
9169 set_code_no_write_barrier( 9169 set_code_no_write_barrier(
9170 GetIsolate()->builtins()->builtin(Builtins::kParallelRecompile)); 9170 GetIsolate()->builtins()->builtin(Builtins::kParallelRecompile));
9171 // No write barrier required, since the builtin is part of the root set. 9171 // No write barrier required, since the builtin is part of the root set.
9172 } 9172 }
9173 9173
9174 9174
9175 void JSFunction::MarkForInstallingRecompiledCode() { 9175 void JSFunction::MarkForInstallingRecompiledCode() {
9176 // The debugger could have switched the builtin to lazy compile. 9176 // The debugger could have switched the builtin to lazy compile.
9177 // In that case, simply carry on. It will be dealt with later. 9177 // In that case, simply carry on. It will be dealt with later.
9178 ASSERT(IsInRecompileQueue() || GetIsolate()->DebuggerHasBreakPoints());
9179 ASSERT(!IsOptimized()); 9178 ASSERT(!IsOptimized());
9180 ASSERT(shared()->allows_lazy_compilation() || code()->optimizable()); 9179 ASSERT(shared()->allows_lazy_compilation() || code()->optimizable());
9181 ASSERT(FLAG_parallel_recompilation); 9180 ASSERT(FLAG_parallel_recompilation);
9182 set_code_no_write_barrier( 9181 set_code_no_write_barrier(
9183 GetIsolate()->builtins()->builtin(Builtins::kInstallRecompiledCode)); 9182 GetIsolate()->builtins()->builtin(Builtins::kInstallRecompiledCode));
9184 // No write barrier required, since the builtin is part of the root set. 9183 // No write barrier required, since the builtin is part of the root set.
9185 } 9184 }
9186 9185
9187 9186
9188 void JSFunction::MarkInRecompileQueue() { 9187 void JSFunction::MarkInRecompileQueue() {
(...skipping 6696 matching lines...) Expand 10 before | Expand all | Expand 10 after
15885 15884
15886 void PropertyCell::AddDependentCode(Handle<Code> code) { 15885 void PropertyCell::AddDependentCode(Handle<Code> code) {
15887 Handle<DependentCode> codes = DependentCode::Insert( 15886 Handle<DependentCode> codes = DependentCode::Insert(
15888 Handle<DependentCode>(dependent_code()), 15887 Handle<DependentCode>(dependent_code()),
15889 DependentCode::kPropertyCellChangedGroup, code); 15888 DependentCode::kPropertyCellChangedGroup, code);
15890 if (*codes != dependent_code()) set_dependent_code(*codes); 15889 if (*codes != dependent_code()) set_dependent_code(*codes);
15891 } 15890 }
15892 15891
15893 15892
15894 } } // namespace v8::internal 15893 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698