Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1876863004: Wait for all device work to finish before destroy VkDevice (Closed)

Created:
4 years, 8 months ago by egdaniel
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Wait for all device work to finish before destroy VkDevice Currently before destroying the GrVkGpu, we do wait on all queue work to finish before destroying objects there. Since we only have one queue, the vkDeviceWaitIdle added here is probably not necessary, but the spec does suggest having it just to make sure all work is fully done on the device. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1876863004 Committed: https://skia.googlesource.com/skia/+/f4ace41dd9590944c9d4f9e3d1c576914db7af18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/gpu/vk/GrVkBackendContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
egdaniel
Sadly this change does not seem to help the bug we've run into where we ...
4 years, 8 months ago (2016-04-11 20:26:12 UTC) #5
jvanverth1
lgtm
4 years, 8 months ago (2016-04-11 20:28:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876863004/1
4 years, 8 months ago (2016-04-11 20:30:39 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 20:41:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f4ace41dd9590944c9d4f9e3d1c576914db7af18

Powered by Google App Engine
This is Rietveld 408576698