Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 187683003: Prevent SkBlockMemoryStream::skip from writing to low memory. (Closed)

Created:
6 years, 9 months ago by bungeman-skia
Modified:
6 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Prevent SkBlockMemoryStream::skip from writing to low memory. SkBlockMemoryStream::read was modeled on SkDynamicMemoryWStream::read. However, SkDynamicMemoryWStream::read does not allow passing a NULL buffer and SkBlockMemoryStream::read must correctly handle this case for skips. In the current code, if a 'skip' crosses a block boundary, 'read' may attempt to write to low memory. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=13671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/core/SkStream.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
It appears this wasn't detected before because we happen to currently never call 'skip' on ...
6 years, 9 months ago (2014-03-05 16:13:48 UTC) #1
robertphillips
lgtm
6 years, 9 months ago (2014-03-05 16:21:23 UTC) #2
bungeman-skia
6 years, 9 months ago (2014-03-05 16:26:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13671.

Powered by Google App Engine
This is Rietveld 408576698