Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1876793002: [stubs] Introduce ModulusStub. (Closed)

Created:
4 years, 8 months ago by epertoso
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
oth, rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Introduce ModulusStub. Adds a ModulusStub for the modulo operator and lets TurboFan and Ignition make use of it. Committed: https://crrev.com/c27c88b493a8865d8ed907f17176df56a8bc143e Cr-Commit-Position: refs/heads/master@{#35389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -6 lines) Patch
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +152 lines, -4 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
epertoso
4 years, 8 months ago (2016-04-11 12:45:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876793002/1
4 years, 8 months ago (2016-04-11 12:45:49 UTC) #4
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-11 12:49:03 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 13:10:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876793002/1
4 years, 8 months ago (2016-04-11 13:41:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 13:54:22 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 13:55:01 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c27c88b493a8865d8ed907f17176df56a8bc143e
Cr-Commit-Position: refs/heads/master@{#35389}

Powered by Google App Engine
This is Rietveld 408576698