Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1876753002: [deoptimizer] Extend assert to also expect kTailCallerFunction as bottommost frame when accessing a… (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Extend assert to also expect kTailCallerFunction as bottommost frame when accessing arguments for inlined function. BUG=chromium:601617, v8:4698 LOG=N Committed: https://crrev.com/26c480d13c19e598103067576a05008319a7b7ac Cr-Commit-Position: refs/heads/master@{#35385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M src/deoptimizer.cc View 1 chunk +2 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-601617.js View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876753002/1
4 years, 8 months ago (2016-04-11 11:08:11 UTC) #2
Igor Sheludko
PTAL
4 years, 8 months ago (2016-04-11 11:08:18 UTC) #4
Jarin
lgtm. Thanks!
4 years, 8 months ago (2016-04-11 11:31:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 11:57:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876753002/1
4 years, 8 months ago (2016-04-11 12:17:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 12:19:28 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 12:20:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26c480d13c19e598103067576a05008319a7b7ac
Cr-Commit-Position: refs/heads/master@{#35385}

Powered by Google App Engine
This is Rietveld 408576698