Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 187673002: MediaStream API: Update RTCIceCandidate to match the Spec (Closed)

Created:
6 years, 9 months ago by Tommy Widenflycht
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, tommyw+watchlist_chromium.org, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

MediaStream API: Update RTCIceCandidate to match the Spec The members of RTCIceCandidate are no longer read-only. BUG=349437 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168586

Patch Set 1 #

Patch Set 2 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -9 lines) Patch
M LayoutTests/fast/mediastream/RTCIceCandidate.html View 1 2 chunks +13 lines, -4 lines 0 comments Download
M LayoutTests/fast/mediastream/RTCIceCandidate-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.h View 1 chunk +4 lines, -1 line 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.cpp View 1 chunk +16 lines, -1 line 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/exported/WebRTCICECandidate.cpp View 2 chunks +22 lines, -0 lines 0 comments Download
M public/platform/WebRTCICECandidate.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tommy Widenflycht
6 years, 9 months ago (2014-03-05 12:42:20 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-05 20:58:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/187673002/20001
6 years, 9 months ago (2014-03-05 21:04:33 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 07:59:41 UTC) #4
Message was sent while issue was closed.
Change committed as 168586

Powered by Google App Engine
This is Rietveld 408576698