Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1876713003: Resurrect ASSERT(isFirstAfterBreak(flowThreadOffset()) || !box.paginationStrut()). (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Resurrect ASSERT(isFirstAfterBreak(flowThreadOffset()) || !box.paginationStrut()). This assertion effectively became disabled by accident by https://codereview.chromium.org/1856373002 , so that fuzzer bug 551312 stopped asserting, although that bug is still very much present. R=leviw@chromium.org Committed: https://crrev.com/930a0d857381d58f3bd6da29253a967ce4481ded Cr-Commit-Position: refs/heads/master@{#386418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M third_party/WebKit/Source/core/layout/ColumnBalancer.cpp View 2 chunks +19 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-11 09:27:14 UTC) #1
leviw_travelin_and_unemployed
lgtm
4 years, 8 months ago (2016-04-11 17:35:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876713003/1
4 years, 8 months ago (2016-04-11 17:36:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 18:23:08 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 18:25:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/930a0d857381d58f3bd6da29253a967ce4481ded
Cr-Commit-Position: refs/heads/master@{#386418}

Powered by Google App Engine
This is Rietveld 408576698