third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 1876653003: Register clipboard image blob in the browser process to copy data less.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 1876653003: Register clipboard image blob in the browser process to copy data less. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add mock interface and fix tests. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/test/mock_webclipboard_impl.cc ('K') | « third_party/WebKit/Source/core/clipboard/DataObjectItem.cpp ('k') | third_party/WebKit/public/blink_headers.gypi » ('j') | third_party/WebKit/public/platform/WebMockClipboard.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index b8821de9d47bf960cac4f6240d389e5e8402f9cf..efbe26d59baa3c7f73bacddc31331b19b12c0d0b 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -64,9 +64,9 @@

#include "platform/testing/URLTestHelpers.h"

#include "platform/testing/UnitTestHelpers.h"

#include "public/platform/Platform.h"

-#include "public/platform/WebClipboard.h"

#include "public/platform/WebDisplayMode.h"

#include "public/platform/WebDragData.h"

+#include "public/platform/WebMockClipboard.h"

#include "public/platform/WebSize.h"

#include "public/platform/WebThread.h"

#include "public/platform/WebURLLoaderMockFactory.h"

@@ -324,8 +324,7 @@ TEST_F(WebViewTest, CopyImageAt)

EXPECT_NE(sequence, Platform::current()->clipboard()->sequenceNumber(WebClipboard::BufferStandard));

- WebData data = Platform::current()->clipboard()->readImage(WebClipboard::Buffer());

- WebImage image = WebImage::fromData(data, WebSize());

+ WebImage image = static_cast<WebMockClipboard*>(Platform::current()->clipboard())->readRawImage(WebClipboard::Buffer());

SkAutoLockPixels autoLock(image.getSkBitmap());

EXPECT_EQ(SkColorSetARGB(255, 255, 0, 0), image.getSkBitmap().getColor(0, 0));