Issue 1876623002: Adds support for a new target spec: 'mac_xcuitest_bundle'. This allows us to create UI testing bund…

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -13 lines)			Patch
M	pylib/gyp/generator/xcode.py	View		4 chunks	+12 lines, -1 line	0 comments	Download
M	pylib/gyp/xcode_emulation.py	View	1 2 3 4 5 6 7 8	3 chunks	+10 lines, -1 line	0 comments	Download
M	pylib/gyp/xcodeproj_file.py	View		2 chunks	+5 lines, -1 line	0 comments	Download
A +	test/mac/gyptest-xcuitest.py	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+7 lines, -6 lines	0 comments	Download
A +	test/mac/xcuitest/Info.plist	View	1 2 7 8 9 10	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mac/xcuitest/MyAppDelegate.h	View	1 2 7 8 9 10	1 chunk	+2 lines, -2 lines	0 comments	Download
A	test/mac/xcuitest/MyAppDelegate.m	View	1 2 3 4 5 6 7 8 9	1 chunk	+19 lines, -0 lines	0 comments	Download
A +	test/mac/xcuitest/TestCase.m	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
A	test/mac/xcuitest/main.m	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+15 lines, -0 lines	0 comments	Download
A +	test/mac/xcuitest/resource.txt	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	test/mac/xcuitest/test.gyp	View	1 2 3 4 5 6	1 chunk	+69 lines, -0 lines	0 comments	Download

Messages

Total messages: 13 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

iwilkins

This CL adds support for XCode UI test bundles to GYP: Bundle type: com.apple.product-type.bundle.ui-testing

4 years, 8 months ago (2016-04-11 16:10:24 UTC) #1

Nico

can you add a test? `python gyptest.py -a` runs tests, `python gyptest.py test/mac` runs a ...

4 years, 8 months ago (2016-04-14 01:50:16 UTC) #5

iwilkins

On 2016/04/14 01:51:33, Nico wrote: > other than that, lg Done. Thanks!

4 years, 8 months ago (2016-04-22 22:13:02 UTC) #9

Nico

lgtm except for one question: https://codereview.chromium.org/1876623002/diff/120001/test/mac/xcuitest/test.gyp File test/mac/xcuitest/test.gyp (right): https://codereview.chromium.org/1876623002/diff/120001/test/mac/xcuitest/test.gyp#newcode20 test/mac/xcuitest/test.gyp:20: 'BUILT_PRODUCTS_DIR': '~/gyppery/gyp/out/testworkarea', is this ...

4 years, 8 months ago (2016-04-25 19:26:28 UTC) #10

iwilkins

Addressed comments. https://codereview.chromium.org/1876623002/diff/120001/test/mac/xcuitest/test.gyp File test/mac/xcuitest/test.gyp (right): https://codereview.chromium.org/1876623002/diff/120001/test/mac/xcuitest/test.gyp#newcode20 test/mac/xcuitest/test.gyp:20: 'BUILT_PRODUCTS_DIR': '~/gyppery/gyp/out/testworkarea', On 2016/04/25 19:26:28, Nico wrote: ...

4 years, 8 months ago (2016-04-25 23:57:44 UTC) #11

Nico

4 years, 8 months ago (2016-04-26 17:27:21 UTC) #13

Message was sent while issue was closed.

Committed patchset #13 (id:300001) manually as
e24c83726b7294179f479a683eeb351568fcc4ee (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1876623002: Adds support for a new target spec: 'mac_xcuitest_bundle'. This allows us to create UI testing bund… (Closed)

Description

Patch Set 1 : Added unit test #

Patch Set 2 : Added a test. #

Patch Set 3 : Added a unit test. #

Patch Set 4 : Line length #

Patch Set 5 : Uploading #

Patch Set 6 : No changes #

Patch Set 7 : Addressed CL comments #

Patch Set 8 : Addressed comments. #

Patch Set 9 : rebase #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : y #

Patch Set 13 : #

Messages