Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 187653006: Activate browser window when opening new tab from a packaged app window. (Closed)

Created:
6 years, 9 months ago by scheib
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Activate browser window when opening new tab from a packaged app window. BUG=345598 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255212

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/ui/apps/chrome_app_window_delegate.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scheib
6 years, 9 months ago (2014-03-05 20:47:53 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 9 months ago (2014-03-05 20:48:47 UTC) #2
scheib
The CQ bit was checked by scheib@chromium.org
6 years, 9 months ago (2014-03-05 21:00:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/187653006/20001
6 years, 9 months ago (2014-03-05 21:02:46 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 21:21:46 UTC) #5
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=156012
6 years, 9 months ago (2014-03-05 21:21:47 UTC) #6
scheib
The CQ bit was checked by scheib@chromium.org
6 years, 9 months ago (2014-03-05 22:39:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/187653006/20001
6 years, 9 months ago (2014-03-05 22:40:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/187653006/20001
6 years, 9 months ago (2014-03-06 00:07:28 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 01:51:12 UTC) #10
Message was sent while issue was closed.
Change committed as 255212

Powered by Google App Engine
This is Rietveld 408576698