Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 187653004: Adds ModuleRegistryObserver interface (Closed)

Created:
6 years, 9 months ago by sky
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Adds ModuleRegistryObserver interface This will be used to know when a module has been added so that I can download needed modules. BUG=none TEST=none R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255291

Patch Set 1 #

Patch Set 2 : observer #

Total comments: 6

Patch Set 3 : merge 2 trunk #

Patch Set 4 : integrate feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -0 lines) Patch
M gin/gin.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M gin/modules/module_registry.h View 1 2 3 3 chunks +11 lines, -0 lines 0 comments Download
M gin/modules/module_registry.cc View 1 2 3 4 chunks +20 lines, -0 lines 0 comments Download
A gin/modules/module_registry_observer.h View 1 chunk +31 lines, -0 lines 0 comments Download
M gin/modules/module_registry_unittest.cc View 2 chunks +66 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sky
I'm also adding RegisterGlobalsObject, which is used to register 'define' on an object.
6 years, 9 months ago (2014-03-05 15:24:55 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/187653004/diff/20001/gin/modules/module_registry.cc File gin/modules/module_registry.cc (right): https://codereview.chromium.org/187653004/diff/20001/gin/modules/module_registry.cc#newcode119 gin/modules/module_registry.cc:119: GetDefineTemplate(isolate)->GetFunction()); Please be aware that this can execute ...
6 years, 9 months ago (2014-03-06 00:32:17 UTC) #2
sky
https://codereview.chromium.org/187653004/diff/20001/gin/modules/module_registry.cc File gin/modules/module_registry.cc (right): https://codereview.chromium.org/187653004/diff/20001/gin/modules/module_registry.cc#newcode119 gin/modules/module_registry.cc:119: GetDefineTemplate(isolate)->GetFunction()); On 2014/03/06 00:32:17, abarth wrote: > Please be ...
6 years, 9 months ago (2014-03-06 00:55:01 UTC) #3
sky
The CQ bit was checked by sky@chromium.org
6 years, 9 months ago (2014-03-06 00:55:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/187653004/60001
6 years, 9 months ago (2014-03-06 00:55:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/187653004/60001
6 years, 9 months ago (2014-03-06 02:53:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/187653004/60001
6 years, 9 months ago (2014-03-06 03:17:51 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 10:28:16 UTC) #8
Message was sent while issue was closed.
Change committed as 255291

Powered by Google App Engine
This is Rietveld 408576698