Add size_t bytesWritten() const to SkWStream.

Add size_t bytesWritten() const to SkWStream.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13684

[robertphillips, 2014-03-05 14:59:12]

lgtm

[reed1, 2014-03-06 14:19:30]

lgtm

[robertphillips, 2014-03-06 14:23:26]

Ben - do you have any thoughts on this?

[bungeman-skia, 2014-03-06 14:54:17]

For Skia issues you want 'bungeman1'; 'bungeman' is rather lax about checking
his mail.

lgtm

[mtklein, 2014-03-06 15:05:50]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-03-06 15:06:02]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/187653003/1

[commit-bot: I haz the power, 2014-03-06 15:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 15:12:41]

Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s)
BuildEverything
http://108.170.219.164:10117/buildstatus?builder=Build-Mac10.8-Clang-x86-Rele...

[mtklein, 2014-03-06 15:28:15]

On 2014/03/06 15:12:41, I haz the power (commit-bot) wrote:
> Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for
step(s)
> BuildEverything
>
http://108.170.219.164:10117/buildstatus?builder=Build-Mac10.8-Clang-x86-Rele...

Mike, can you take a look at PS 2, adding SkToSizeT()?

[reed1, 2014-03-06 15:56:16]

lgtm

[mtklein, 2014-03-06 16:22:05]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-03-06 16:22:12]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/187653003/20001

[commit-bot: I haz the power, 2014-03-06 17:16:29]

Change committed as 13684

[hal.canary, 2014-03-06 18:23:45]

https://codereview.chromium.org/187653003/diff/20001/src/core/SkStream.cpp
File src/core/SkStream.cpp (right):

https://codereview.chromium.org/187653003/diff/20001/src/core/SkStream.cpp#ne...
src/core/SkStream.cpp:822: #endif
are you sure this isn't just size?  printf doesn't write the trailing '\0',
that's just a signal to stop printing.

In Release, should fBytesWritten always == 0?  That's what this seems to do.

[mtklein, 2014-03-06 18:28:11]

https://codereview.chromium.org/187653003/diff/20001/src/core/SkStream.cpp
File src/core/SkStream.cpp (right):

https://codereview.chromium.org/187653003/diff/20001/src/core/SkStream.cpp#ne...
src/core/SkStream.cpp:822: #endif
On 2014/03/06 18:23:45, Hal Canary wrote:
> are you sure this isn't just size?  printf doesn't write the trailing '\0',
> that's just a signal to stop printing.
> 
> In Release, should fBytesWritten always == 0?  That's what this seems to do.

Oh, good catch.  This should be += size.

It seems fine that bytesWritten() always returns 0 in release.  It's consistent
with the bytes actually written.

[reed1, 2014-03-06 19:16:56]

Can we captures these notions of correctness in some unittests for this new API?