Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1876493002: Makes browser_tests depend upon mojo manifests (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes browser_tests depend upon mojo manifests These are read for browser_tests. BUG=594600 TEST=none R=rockot@chromium.org Committed: https://crrev.com/6ccb5f15535dcf49a334cdb4a00ad4a11b72ae76 Cr-Commit-Position: refs/heads/master@{#386196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 8 months ago (2016-04-08 20:06:34 UTC) #1
Ken Rockot(use gerrit already)
lgtm
4 years, 8 months ago (2016-04-08 20:12:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876493002/1
4 years, 8 months ago (2016-04-08 20:19:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 21:03:27 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 21:04:42 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6ccb5f15535dcf49a334cdb4a00ad4a11b72ae76
Cr-Commit-Position: refs/heads/master@{#386196}

Powered by Google App Engine
This is Rietveld 408576698