Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1876473002: Add a feature flag for enabling subscription restrictions (Closed)

Created:
4 years, 8 months ago by Peter Beverloo
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, johnme+watch_chromium.org, jam, mvanouwerkerk+watch_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, mkwst+moarreviews-shell_chromium.org, harkness+watch_chromium.org, blink-reviews-api_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a feature flag for enabling subscription restrictions BUG=

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -38 lines) Patch
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_constants.h View 1 2 1 chunk +1 line, -0 lines 1 comment Download
M chrome/browser/push_messaging/push_messaging_constants.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_unittest.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/push_messaging/push_messaging_message_filter.h View 1 2 3 chunks +18 lines, -4 lines 0 comments Download
M content/browser/push_messaging/push_messaging_message_filter.cc View 1 2 10 chunks +58 lines, -18 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/push_messaging_service.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/common/content_features.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 1 chunk +6 lines, -0 lines 1 comment Download
M content/shell/browser/layout_test/layout_test_push_messaging_service.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_push_messaging_service.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Peter Beverloo
+mvanouwerkerk for review
4 years, 8 months ago (2016-04-15 15:49:36 UTC) #3
Michael van Ouwerkerk
4 years, 8 months ago (2016-04-15 16:13:41 UTC) #4 
https://codereview.chromium.org/1876473002/diff/60001/chrome/browser/push_mes...
File chrome/browser/push_messaging/push_messaging_constants.h (right):

https://codereview.chromium.org/1876473002/diff/60001/chrome/browser/push_mes...
chrome/browser/push_messaging/push_messaging_constants.h:8: extern const char
kPushMessagingEndpoint[];
Maybe rename this one to kPushMessagingGcmEndpoint?

https://codereview.chromium.org/1876473002/diff/60001/content/public/common/c...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/1876473002/diff/60001/content/public/common/c...
content/public/common/content_features.cc:89: // Enables support for restricting
push messaging subscriptions to a specific
I would expect that the WebPushProtocol feature enables use of the Web Push
Protocol, but this description is quite different. Is this a typo or do we need
to have a chat?

Powered by Google App Engine
This is Rietveld 408576698