Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 187643002: Remove unused TimerData that generates errors (Closed)

Created:
6 years, 9 months ago by iancottrell
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove unused TimerData that generates errors As far as I can tell all uses of TimerData::appendTimes were stripped out in https://chromiumcodereview.appspot.com/23121002 but the surrounding code was left in, causing it to print errors when there are none. BUG=skia:2242 Committed: http://code.google.com/p/skia/source/detail?r=13672

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review fixes #

Patch Set 3 : Mac build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -35 lines) Patch
M tools/bbh_shootout.cpp View 1 2 3 chunks +2 lines, -35 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
iancottrell
6 years, 9 months ago (2014-03-05 13:20:20 UTC) #1
mtklein
Just some nits to fix up before submitting. Intern code is always fun. lgtm https://codereview.chromium.org/187643002/diff/1/tools/bbh_shootout.cpp ...
6 years, 9 months ago (2014-03-05 15:04:53 UTC) #2
tomhudson
lgtm
6 years, 9 months ago (2014-03-05 15:06:34 UTC) #3
iancottrell
https://codereview.chromium.org/187643002/diff/1/tools/bbh_shootout.cpp File tools/bbh_shootout.cpp (right): https://codereview.chromium.org/187643002/diff/1/tools/bbh_shootout.cpp#newcode300 tools/bbh_shootout.cpp:300: * Returns a SkScalar representing CPU time taken during ...
6 years, 9 months ago (2014-03-05 15:41:11 UTC) #4
iancottrell
The CQ bit was checked by iancottrell@google.com
6 years, 9 months ago (2014-03-05 15:41:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/iancottrell@google.com/187643002/20001
6 years, 9 months ago (2014-03-05 15:41:22 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 16:01:11 UTC) #7
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildTools http://108.170.219.164:10117/buildstatus?builder=Build-Mac10.8-Clang-x86-Release-Trybot&number=191
6 years, 9 months ago (2014-03-05 16:01:12 UTC) #8
iancottrell
The CQ bit was checked by iancottrell@google.com
6 years, 9 months ago (2014-03-05 16:12:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/iancottrell@google.com/187643002/40001
6 years, 9 months ago (2014-03-05 16:12:22 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 17:09:47 UTC) #11
Message was sent while issue was closed.
Change committed as 13672

Powered by Google App Engine
This is Rietveld 408576698