Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: cc/scheduler/begin_frame_tracker.cc

Issue 1876413003: cc: Copy category/arg names for tracing in BeginFrameTracker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use TRACE_EVENT_COPY... instead of TRACE_STR_COPY Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/begin_frame_tracker.cc
diff --git a/cc/scheduler/begin_frame_tracker.cc b/cc/scheduler/begin_frame_tracker.cc
index 20e2c39376d83b2049bf119c63dab87ad1256dfa..dc18beaa4d37718623e61bbdb9581dc609271a9c 100644
--- a/cc/scheduler/begin_frame_tracker.cc
+++ b/cc/scheduler/begin_frame_tracker.cc
@@ -23,7 +23,7 @@ void BeginFrameTracker::Start(BeginFrameArgs new_args) {
new_args.frame_time.ToInternalValue(), location_string_);
// Trace this specific begin frame tracker Start/Finish times.
- TRACE_EVENT_ASYNC_BEGIN2(
+ TRACE_EVENT_COPY_ASYNC_BEGIN2(
TRACE_DISABLED_BY_DEFAULT("cc.debug.scheduler.frames"),
location_string_.c_str(), new_args.frame_time.ToInternalValue(),
"new args", new_args.AsValue(), "current args", current_args_.AsValue());
@@ -54,9 +54,9 @@ const BeginFrameArgs& BeginFrameTracker::Current() const {
void BeginFrameTracker::Finish() {
DCHECK(!HasFinished()) << "Tried to finish an already finished frame";
current_finished_at_ = base::TimeTicks::Now();
- TRACE_EVENT_ASYNC_END0(TRACE_DISABLED_BY_DEFAULT("cc.debug.scheduler.frames"),
- location_string_.c_str(),
- current_args_.frame_time.ToInternalValue());
+ TRACE_EVENT_COPY_ASYNC_END0(
+ TRACE_DISABLED_BY_DEFAULT("cc.debug.scheduler.frames"),
+ location_string_.c_str(), current_args_.frame_time.ToInternalValue());
}
const BeginFrameArgs& BeginFrameTracker::Last() const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698