Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: third_party/WebKit/Source/platform/heap/HeapPage.h

Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate Haraken's wonderful comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/HeapPage.h
diff --git a/third_party/WebKit/Source/platform/heap/HeapPage.h b/third_party/WebKit/Source/platform/heap/HeapPage.h
index bb54094a1d36f75d643424a1a8c381a2b14357a1..bcedc4c0c0a1ab095f71e5d22750536f72301e13 100644
--- a/third_party/WebKit/Source/platform/heap/HeapPage.h
+++ b/third_party/WebKit/Source/platform/heap/HeapPage.h
@@ -205,6 +205,9 @@ public:
ASSERT(size < nonLargeObjectPageSizeMax);
m_encoded = static_cast<uint32_t>(size) | (m_encoded & ~headerSizeMask);
}
+ bool isDOMMarked() const;
+ void markDOM();
+ void unmarkDOM();
haraken 2016/04/13 12:26:23 isDOMMarked => isWrappableMarked markDOM => markWr
Marcel Hlopko 2016/04/14 16:39:08 Done.
bool isMarked() const;
void mark();
void unmark();
@@ -835,6 +838,29 @@ inline HeapObjectHeader* HeapObjectHeader::fromPayload(const void* payload)
}
NO_SANITIZE_ADDRESS inline
+bool HeapObjectHeader::isDOMMarked() const
+{
+ ASSERT(checkHeader());
+ return m_encoded & headerDOMMarkBitMask;
haraken 2016/04/13 12:26:22 Where is headerDOMMarkBitMask defined?
Marcel Hlopko 2016/04/14 16:39:08 HeapPage.h:145 const size_t headerDOMMarkBitMask =
+}
+
+NO_SANITIZE_ADDRESS inline
+void HeapObjectHeader::markDOM()
+{
+ ASSERT(checkHeader());
+ ASSERT(!isDOMMarked());
+ m_encoded |= headerDOMMarkBitMask;
+}
+
+NO_SANITIZE_ADDRESS inline
+void HeapObjectHeader::unmarkDOM()
+{
+ ASSERT(checkHeader());
+ ASSERT(isDOMMarked());
+ m_encoded &= ~headerDOMMarkBitMask;
+}
+
+NO_SANITIZE_ADDRESS inline
bool HeapObjectHeader::isMarked() const
{
ASSERT(checkHeader());

Powered by Google App Engine
This is Rietveld 408576698