third_party/WebKit/Source/core/dom/Node.cpp - Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate Haraken's wonderful comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCController.h ('K') | « third_party/WebKit/Source/core/dom/Node.h ('k') | third_party/WebKit/Source/core/dom/Node.idl » ('j') | third_party/WebKit/Source/platform/heap/HeapPage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Node.cpp

diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp

index a4045106859b7e4c826f9454f50db7776a577b3f..b870e48746b32d1ed7ebdfde1b74e37a7dab3379 100644

--- a/third_party/WebKit/Source/core/dom/Node.cpp

+++ b/third_party/WebKit/Source/core/dom/Node.cpp

@@ -339,6 +339,11 @@ NodeRareData* Node::rareData() const

return static_cast<NodeRareData*>(m_data.m_rareData);

}

+NodeRareData* Node::maybeRareData() const

haraken 2016/04/13 12:26:22 maybeRareData => rareDataForTraceWrappers (to clar

Marcel Hlopko 2016/04/14 16:39:08 Removed completely, I'll write traceWrappers for N

+ return hasRareData() ? rareData() : nullptr;

NodeRareData& Node::ensureRareData()

{

if (hasRareData())