Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate Haraken's wonderful comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
index a6150c7bba563e01834d4a6b2e3ea9302a807b9f..b13241ad1087796971ee5fa15088ecb546959e89 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
@@ -31,6 +31,7 @@
#ifndef ScriptWrappable_h
#define ScriptWrappable_h
+#include "bindings/core/v8/ScriptWrappableVisitor.h"
#include "bindings/core/v8/WrapperTypeInfo.h"
#include "core/CoreExport.h"
#include "platform/heap/Handle.h"
@@ -149,6 +150,14 @@ public:
bool containsWrapper() const { return !m_wrapper.IsEmpty(); }
+ static void markWrapperAlive(const v8::Persistent<v8::Object>& handle, v8::Isolate*);
+ void markWrapperAlive(v8::Isolate* isolate) const
haraken 2016/04/13 12:26:22 markWrapperAlive => markWrappers?
Marcel Hlopko 2016/04/14 16:39:08 Done.
+ {
+ markWrapperAlive(m_wrapper, isolate);
+ }
+
+ DECLARE_VIRTUAL_TRACE_WRAPPERS() {};
+
// With Oilpan we don't need a ScriptWrappable destructor.
//
// 'RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(!containsWrapper())' is not needed

Powered by Google App Engine
This is Rietveld 408576698