third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h - Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix var used only in assert Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

index a6150c7bba563e01834d4a6b2e3ea9302a807b9f..31597a055943bbbb7ed536f12639719273fd29e9 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

@@ -31,6 +31,7 @@

#ifndef ScriptWrappable_h

#define ScriptWrappable_h

+#include "bindings/core/v8/ScriptWrappableVisitor.h"

#include "bindings/core/v8/WrapperTypeInfo.h"

#include "core/CoreExport.h"

#include "platform/heap/Handle.h"

@@ -149,6 +150,15 @@ public:

bool containsWrapper() const { return !m_wrapper.IsEmpty(); }

+ /**

+ * Mark wrapper of this ScriptWrappable as alive in V8. Only marks

+ * wrapper in the main world. To mark wrappers in all worlds call

+ * ScriptWrappableVisitor::markWrapper(ScriptWrappable*, v8::Isolate*)

+ */

+ void markWrapper(v8::Isolate*) const;

+ DECLARE_VIRTUAL_TRACE_WRAPPERS() {};

// With Oilpan we don't need a ScriptWrappable destructor.

// 'RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(!containsWrapper())' is not needed