third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp - Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use newer v8 api Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptWrappableHeapTracer.h » ('j') | third_party/WebKit/Source/bindings/core/v8/ScriptWrappableHeapTracer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

index 3534a4ebfb5d2b1cd83854203e91f08945483b90..9a49c8d637005ea44487f94ea1ca907f3d718961 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

@@ -5,6 +5,7 @@

#include "bindings/core/v8/ScriptWrappable.h"

#include "bindings/core/v8/DOMDataStore.h"

+#include "bindings/core/v8/ScriptWrappableHeapTracer.h"

#include "bindings/core/v8/V8DOMWrapper.h"

namespace blink {

@@ -35,4 +36,10 @@ v8::Local<v8::Object> ScriptWrappable::associateWithWrapper(v8::Isolate* isolate

return V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperTypeInfo, wrapper);

}

+void ScriptWrappable::markWrapper(v8::Isolate* isolate) const

+ if (containsWrapper())

+ ScriptWrappableHeapTracer::markWrapper(m_wrapper, isolate);

} // namespace blink