third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h - Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use newer v8 api Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt ('K') | « third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h » ('j') | third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h b/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

index 62484cd14861a310549c7111a919b2e2a084a0b8..7cdc70cb3d1f6a94c7fb00ea59ec2f6ecbf5543c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

+++ b/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

@@ -153,6 +153,11 @@ public:

return m_wrapperMap->newLocal(isolate, object);

}

+ void markWrapper(ScriptWrappable* scriptWrappable, v8::Isolate* isolate)

haraken 2016/04/19 04:58:30 Remove the isolate parameter.

Marcel Hlopko 2016/04/19 12:40:29 Done.

+ {

+ m_wrapperMap->markWrapper(scriptWrappable);

+ }

void setReference(const v8::Persistent<v8::Object>& parent, ScriptWrappable* child, v8::Isolate* isolate)

{

if (m_isMainWorld) {