Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert to traceActiveScriptWrappables - C++ is happier Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h b/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
index 62484cd14861a310549c7111a919b2e2a084a0b8..eee3802cfd843abfec60f9a3a73c574cc146d732 100644
--- a/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
+++ b/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
@@ -153,6 +153,14 @@ public:
return m_wrapperMap->newLocal(isolate, object);
}
+ void markWrapper(ScriptWrappable* scriptWrappable, v8::Isolate* isolate)
+ {
+ if (m_isMainWorld)
+ scriptWrappable->markWrapper(isolate);
haraken 2016/04/18 04:35:41 Sorry, this would be a bug of the existing binding
Marcel Hlopko 2016/04/18 11:45:34 Yeah, I see. Good catch. I fixed the code.
+ else
+ m_wrapperMap->markWrapper(scriptWrappable);
+ }
+
void setReference(const v8::Persistent<v8::Object>& parent, ScriptWrappable* child, v8::Isolate* isolate)
{
if (m_isMainWorld) {

Powered by Google App Engine
This is Rietveld 408576698