Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 1876383003: Introduce infrastructure for tracing ScriptWrappables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert to traceActiveScriptWrappables - C++ is happier Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef ScriptWrappable_h 31 #ifndef ScriptWrappable_h
32 #define ScriptWrappable_h 32 #define ScriptWrappable_h
33 33
34 #include "bindings/core/v8/ScriptWrappableVisitor.h"
34 #include "bindings/core/v8/WrapperTypeInfo.h" 35 #include "bindings/core/v8/WrapperTypeInfo.h"
35 #include "core/CoreExport.h" 36 #include "core/CoreExport.h"
36 #include "platform/heap/Handle.h" 37 #include "platform/heap/Handle.h"
37 #include "wtf/Noncopyable.h" 38 #include "wtf/Noncopyable.h"
38 #include "wtf/TypeTraits.h" 39 #include "wtf/TypeTraits.h"
39 #include <v8.h> 40 #include <v8.h>
40 41
41 namespace blink { 42 namespace blink {
42 43
43 /** 44 /**
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 return containsWrapper(); 143 return containsWrapper();
143 } 144 }
144 145
145 void setReference(const v8::Persistent<v8::Object>& parent, v8::Isolate* iso late) 146 void setReference(const v8::Persistent<v8::Object>& parent, v8::Isolate* iso late)
146 { 147 {
147 isolate->SetReference(parent, m_wrapper); 148 isolate->SetReference(parent, m_wrapper);
148 } 149 }
149 150
150 bool containsWrapper() const { return !m_wrapper.IsEmpty(); } 151 bool containsWrapper() const { return !m_wrapper.IsEmpty(); }
151 152
153 void markWrapper(v8::Isolate*) const;
154
155 DECLARE_VIRTUAL_TRACE_WRAPPERS() {};
156
152 // With Oilpan we don't need a ScriptWrappable destructor. 157 // With Oilpan we don't need a ScriptWrappable destructor.
153 // 158 //
154 // 'RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(!containsWrapper())' is not nee ded 159 // 'RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(!containsWrapper())' is not nee ded
155 // because Oilpan is not using reference counting at all. If containsWrapper () is true, 160 // because Oilpan is not using reference counting at all. If containsWrapper () is true,
156 // it means that ScriptWrappable still has a wrapper. In this case, the dest ructor 161 // it means that ScriptWrappable still has a wrapper. In this case, the dest ructor
157 // must not be called since the wrapper has a persistent handle back to this ScriptWrappable object. 162 // must not be called since the wrapper has a persistent handle back to this ScriptWrappable object.
158 // Assuming that Oilpan's GC is correct (If we cannot assume this, a lot of more things are 163 // Assuming that Oilpan's GC is correct (If we cannot assume this, a lot of more things are
159 // already broken), we must not hit the RELEASE_ASSERT. 164 // already broken), we must not hit the RELEASE_ASSERT.
160 165
161 private: 166 private:
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 // in X's cpp code, and instantiate X, i.e. "template class X;". 212 // in X's cpp code, and instantiate X, i.e. "template class X;".
208 #define DECLARE_WRAPPERTYPEINFO() \ 213 #define DECLARE_WRAPPERTYPEINFO() \
209 public: \ 214 public: \
210 const WrapperTypeInfo* wrapperTypeInfo() const override; \ 215 const WrapperTypeInfo* wrapperTypeInfo() const override; \
211 private: \ 216 private: \
212 typedef void end_of_define_wrappertypeinfo_not_reached_t 217 typedef void end_of_define_wrappertypeinfo_not_reached_t
213 218
214 } // namespace blink 219 } // namespace blink
215 220
216 #endif // ScriptWrappable_h 221 #endif // ScriptWrappable_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698