tools/dom/templates/html/impl/impl_EventTarget.darttemplate - Issue 1876363006: Fix a few strong mode errors in dart:html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_EventTarget.darttemplate

Issue 1876363006: Fix a few strong mode errors in dart:html (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Reverted the move of fullscreenEnabled, causes duplicate definitions in dart2js Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/templates/html/impl/impl_Event.darttemplate ('k') | tools/dom/templates/html/impl/impl_MessageEvent.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/impl/impl_EventTarget.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_EventTarget.darttemplate b/tools/dom/templates/html/impl/impl_EventTarget.darttemplate

index 61092fd02f22f160d83fb85dfd22afc5bf2ac61a..c6d74ef5691b55ae6d942f04bbda3d186e1d84fc 100644

--- a/tools/dom/templates/html/impl/impl_EventTarget.darttemplate

+++ b/tools/dom/templates/html/impl/impl_EventTarget.darttemplate

@@ -52,26 +52,24 @@ class Events {

}

class ElementEvents extends Events {

- /* Raw event target. */

- final Element _ptr;

static final webkitEvents = {

- 'animationend' : 'webkitAnimationEnd',

- 'animationiteration' : 'webkitAnimationIteration',

- 'animationstart' : 'webkitAnimationStart',

- 'fullscreenchange' : 'webkitfullscreenchange',

+ 'animationend' : 'webkitAnimationEnd',

+ 'animationiteration' : 'webkitAnimationIteration',

+ 'animationstart' : 'webkitAnimationStart',

+ 'fullscreenchange' : 'webkitfullscreenchange',

'fullscreenerror' : 'webkitfullscreenerror',

- 'keyadded' : 'webkitkeyadded',

- 'keyerror' : 'webkitkeyerror',

- 'keymessage' : 'webkitkeymessage',

- 'needkey' : 'webkitneedkey',

- 'pointerlockchange' : 'webkitpointerlockchange',

- 'pointerlockerror' : 'webkitpointerlockerror',

- 'resourcetimingbufferfull' : 'webkitresourcetimingbufferfull',

+ 'keyadded' : 'webkitkeyadded',

+ 'keyerror' : 'webkitkeyerror',

+ 'keymessage' : 'webkitkeymessage',

+ 'needkey' : 'webkitneedkey',

+ 'pointerlockchange' : 'webkitpointerlockchange',

+ 'pointerlockerror' : 'webkitpointerlockerror',

+ 'resourcetimingbufferfull' : 'webkitresourcetimingbufferfull',

'transitionend': 'webkitTransitionEnd',

'speechchange' : 'webkitSpeechChange'

};

- ElementEvents(Element ptr) : this._ptr = ptr, super(ptr);

+ ElementEvents(Element ptr) : super(ptr);

Stream operator [](String type) {

if (webkitEvents.keys.contains(type.toLowerCase())) {