- Ensure that we do not enter symbols twice: Set the canonical bit

- Ensure that we do not enter symbols twice: Set the canonical bit
  on a String once we know it is canonical.
- Bug fix in hash set implementation.

BUG=

Committed: https://github.com/dart-lang/sdk/commit/23a4e3da53800e052b4993cce071dedc3aef2bd9

[Ivan Posva, 2016-04-12 04:57:16]

iposva@google.com changed reviewers:
+ fschneider@google.com

[Ivan Posva, 2016-04-12 05:05:31]

Description was changed from

==========
- Ensure that we do not enter symbols twice: Set the canonical bit
  on a String once we know it is canonical.
- Bug fix in hash set implementation.

BUG=
==========

to

==========
- Ensure that we do not enter symbols twice: Set the canonical bit
  on a String once we know it is canonical.
- Bug fix in hash set implementation.

BUG=

Committed:
https://github.com/dart-lang/sdk/commit/23a4e3da53800e052b4993cce071dedc3aef2bd9
==========

[Ivan Posva, 2016-04-12 05:05:33]

Committed patchset #1 (id:1) manually as
23a4e3da53800e052b4993cce071dedc3aef2bd9 (presubmit successful).

[Florian Schneider, 2016-04-12 05:49:03]

lgtm

https://codereview.chromium.org/1876363003/diff/1/runtime/vm/hash_table.h
File runtime/vm/hash_table.h (left):

https://codereview.chromium.org/1876363003/diff/1/runtime/vm/hash_table.h#old...
runtime/vm/hash_table.h:639: return BaseIterTable::GetPayload(entry, 0);
Oops. Good catch.

https://codereview.chromium.org/1876363003/diff/1/runtime/vm/symbols.cc
File runtime/vm/symbols.cc (right):

https://codereview.chromium.org/1876363003/diff/1/runtime/vm/symbols.cc#newco...
runtime/vm/symbols.cc:220: RawString* entry =
reinterpret_cast<RawString*>(table.InsertOrGet(*str));
Shorter: *str ^= table.InsertOrGet(*str);

https://codereview.chromium.org/1876363003/diff/1/runtime/vm/symbols.cc#newco...
runtime/vm/symbols.cc:235: RawString* entry =
reinterpret_cast<RawString*>(table.InsertOrGet(*str));
Ditto.

[Ivan Posva, 2016-04-12 05:52:10]

Thanks!

-Ivan

https://codereview.chromium.org/1876363003/diff/1/runtime/vm/symbols.cc
File runtime/vm/symbols.cc (right):

https://codereview.chromium.org/1876363003/diff/1/runtime/vm/symbols.cc#newco...
runtime/vm/symbols.cc:220: RawString* entry =
reinterpret_cast<RawString*>(table.InsertOrGet(*str));
On 2016/04/12 05:49:03, Florian Schneider wrote:
> Shorter: *str ^= table.InsertOrGet(*str);

Done. Missed the right combination with * and ^ when trying. Will be in a
followup CL.

https://codereview.chromium.org/1876363003/diff/1/runtime/vm/symbols.cc#newco...
runtime/vm/symbols.cc:235: RawString* entry =
reinterpret_cast<RawString*>(table.InsertOrGet(*str));
On 2016/04/12 05:49:03, Florian Schneider wrote:
> Ditto.

Done.