Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1876353006: Add Mojo{Set,Get}DataPipeProducerOptions() to the NaCl system thunks. (Closed)

Created:
4 years, 8 months ago by viettrungluu
Modified:
4 years, 8 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add Mojo{Set,Get}DataPipeProducerOptions() to the NaCl system thunks. This is just like 58ec2b7917fbe3241e9352fc338990aae878c72c, but for producer options rather than consumer (and I didn't mess up adding the native system thunks). R=vardhan@google.com BUG=#442 Committed: https://chromium.googlesource.com/external/mojo/+/d1825d259414e6a42dd043591a74dfeb98bd1067

Patch Set 1 #

Patch Set 2 : gah #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -37 lines) Patch
M mojo/edk/embedder/system_impl_private_entrypoints.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M mojo/nacl/nonsfi/irt_mojo_nonsfi.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings/mojo_irt.c View 15 chunks +43 lines, -13 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings/mojo_syscall.cc View 10 chunks +82 lines, -12 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings_generator/interface.py View 1 chunk +11 lines, -0 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 1 4 chunks +14 lines, -12 lines 0 comments Download
M mojo/public/platform/nacl/libmojo.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M mojo/public/platform/nacl/mojo_irt.h View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private.h View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_thunks.h View 2 chunks +11 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_thunks.c View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 8 months ago (2016-04-13 23:29:49 UTC) #1
vardhan
trybots fail for Linux debug (specifically for a nacl test). lgtm otherwise
4 years, 8 months ago (2016-04-13 23:57:29 UTC) #2
viettrungluu
Thanks. On 2016/04/13 23:57:29, vardhan wrote: > trybots fail for Linux debug (specifically for a ...
4 years, 8 months ago (2016-04-14 00:04:29 UTC) #3
viettrungluu
4 years, 8 months ago (2016-04-14 00:13:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d1825d259414e6a42dd043591a74dfeb98bd1067 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698