Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5993)

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Issue 1876293002: [Mac][Material Design] Center elements within the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extension_button_rework
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
index 31b1b2f493cd95f858a43b1abef22d41181bb92f..4a669c2f882d8832a8686570be5f4662160b6006 100644
--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
@@ -308,8 +308,7 @@ class NotificationBridge : public AppMenuBadgeController::Delegate {
backButtonFrame.origin.x =
kMaterialDesignElementPadding + kMaterialDesignButtonInset;
backButtonFrame.origin.y = NSMaxY(toolbarBounds) -
- kMaterialDesignElementPadding - kMaterialDesignButtonInset -
- toolbarButtonSize.height;
+ kMaterialDesignElementPadding - toolbarButtonSize.height;
backButtonFrame.size = toolbarButtonSize;
[backButton_ setFrame:backButtonFrame];
@@ -360,8 +359,8 @@ class NotificationBridge : public AppMenuBadgeController::Delegate {
NSRect locationBarFrame = [locationBar_ frame];
locationBarFrame.origin.x = NSMaxX(homeButtonFrame) +
kMaterialDesignButtonInset;
- locationBarFrame.origin.y = NSMaxY(toolbarBounds) -
- kMaterialDesignElementPadding - kMaterialDesignLocationBarHeight;
+ locationBarFrame.origin.y = NSMaxY(toolbarBounds) - 2 -
Avi (use Gerrit) 2016/04/11 21:32:06 Is this "2" related to a constant somehow? An inse
+ kMaterialDesignLocationBarHeight;
locationBarFrame.size.width =
menuButtonFrame.origin.x -
locationBarFrame.origin.x;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698