Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1876293002: [Mac][Material Design] Center elements within the toolbar. (Closed)

Created:
4 years, 8 months ago by shrike
Modified:
4 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@extension_button_rework
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Center elements within the toolbar. This cl fixes a regression in https://codereview.chromium.org/187033300 that leaves the toolbar's elements no longer vertically centered within the toolbar. R=avi@chromium.org BUG=602393 Committed: https://crrev.com/4a9a39e0a0e2bd60e1ebd81b0dcac4a3525f64e3 Cr-Commit-Position: refs/heads/master@{#386519}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Create constant for location bar padding. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
shrike
PTAL
4 years, 8 months ago (2016-04-11 21:25:51 UTC) #1
Avi (use Gerrit)
https://codereview.chromium.org/1876293002/diff/1/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right): https://codereview.chromium.org/1876293002/diff/1/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm#newcode362 chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:362: locationBarFrame.origin.y = NSMaxY(toolbarBounds) - 2 - Is this "2" ...
4 years, 8 months ago (2016-04-11 21:32:06 UTC) #2
shrike
On 2016/04/11 21:32:06, Avi wrote: > https://codereview.chromium.org/1876293002/diff/1/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm > File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right): > > https://codereview.chromium.org/1876293002/diff/1/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm#newcode362 > ...
4 years, 8 months ago (2016-04-11 21:36:03 UTC) #3
Avi (use Gerrit)
On 2016/04/11 21:36:03, shrike wrote: > On 2016/04/11 21:32:06, Avi wrote: > > > https://codereview.chromium.org/1876293002/diff/1/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm ...
4 years, 8 months ago (2016-04-11 21:40:03 UTC) #4
shrike
On 2016/04/11 21:40:03, Avi wrote: > On 2016/04/11 21:36:03, shrike wrote: > > On 2016/04/11 ...
4 years, 8 months ago (2016-04-11 21:44:04 UTC) #5
Avi (use Gerrit)
lgtm Thanks!
4 years, 8 months ago (2016-04-11 21:46:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876293002/20001
4 years, 8 months ago (2016-04-11 21:47:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 23:47:20 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 23:48:15 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a9a39e0a0e2bd60e1ebd81b0dcac4a3525f64e3
Cr-Commit-Position: refs/heads/master@{#386519}

Powered by Google App Engine
This is Rietveld 408576698