Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: chrome/test/data/webui/settings/startup_urls_page_test.js

Issue 1876283002: MD Settings: On Startup, moving remove URL option under a dots menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@edit_on_startup_cpp
Patch Set: Typo. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/startup_urls_page_test.js
diff --git a/chrome/test/data/webui/settings/startup_urls_page_test.js b/chrome/test/data/webui/settings/startup_urls_page_test.js
index 038017ee7abc6211dbc845b8208d52b268a873d4..54f98fabe1edc6f108e07e95604086a32bafc6af 100644
--- a/chrome/test/data/webui/settings/startup_urls_page_test.js
+++ b/chrome/test/data/webui/settings/startup_urls_page_test.js
@@ -12,6 +12,7 @@ cr.define('settings_startup_urls_page', function() {
settings.TestBrowserProxy.call(this, [
'addStartupPage',
'loadStartupPages',
+ 'removeStartupPage',
'useCurrentPages',
'validateStartupPage',
]);
@@ -40,6 +41,11 @@ cr.define('settings_startup_urls_page', function() {
},
/** @override */
+ removeStartupPage: function(modelIndex) {
+ this.methodCalled('removeStartupPage', modelIndex);
+ },
+
+ /** @override */
useCurrentPages: function() {
this.methodCalled('useCurrentPages');
},
@@ -168,4 +174,47 @@ cr.define('settings_startup_urls_page', function() {
assertTrue(!!page.$$('settings-startup-url-dialog'));
});
});
+
+ /** @return {!StartupPageInfo} */
+ function createSampleUrlEntry() {
+ return {
+ modelIndex: 2,
+ title: 'Test page',
+ tooltip: 'test tooltip',
+ url: 'chrome://foo',
+ };
+ }
+
+ suite('StartupUrlEntry', function() {
+ /** @type {?SettingsStartupUrlEntryElement} */
+ var element = null;
+
+ var browserProxy = null;
+
+ setup(function() {
+ browserProxy = new TestStartupUrlsPageBrowserProxy();
+ settings.StartupUrlsPageBrowserProxyImpl.instance_ = browserProxy;
+ PolymerTest.clearBody();
+ element = document.createElement('settings-startup-url-entry');
+ element.model = createSampleUrlEntry();
+ document.body.appendChild(element);
+
+ // Bring up the popup menu for the following tests to use.
+ assertFalse(!!element.$$('iron-dropdown'));
+ MockInteractions.tap(element.$.dots);
+ Polymer.dom.flush();
+ assertTrue(!!element.$$('iron-dropdown'));
+ });
+
+ teardown(function() { element.remove(); });
+
+ test('MenuOptions_Remove', function() {
+ var removeButton = element.shadowRoot.querySelector('#remove')
+ MockInteractions.tap(removeButton);
+ return browserProxy.whenCalled('removeStartupPage').then(
+ function(modelIndex) {
+ assertEquals(element.model.modelIndex, modelIndex);
+ });
+ });
+ });
});
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698