Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

Issue 1876283002: MD Settings: On Startup, moving remove URL option under a dots menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@edit_on_startup_cpp
Patch Set: Typo. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
index 18f79048d56233155feffdab5b20669d58645ef9..a3d0fabd227323c50cca2273910b8f47cc47d6b4 100644
--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
@@ -7,15 +7,6 @@
* containing the urls that will be opened when chrome is started.
*/
-/**
- * @typedef {{
- * title: string,
- * tooltip: string,
- * url: string
- * }}
- */
-var StartupPageInfo;
-
Polymer({
is: 'settings-startup-urls-page',
@@ -44,15 +35,6 @@ Polymer({
},
/**
- * @param {string} url Location of an image to get a set of icons fors.
- * @return {string} A set of icon URLs.
- * @private
- */
- getIconSet_: function(url) {
- return getFaviconImageSet(url);
- },
-
- /**
* Opens the dialog and registers a listener for removing the dialog from the
* DOM once is closed. The listener is destroyed when the dialog is removed
* (because of 'restamp').
@@ -72,12 +54,4 @@ Polymer({
onUseCurrentPagesTap_: function() {
this.browserProxy_.useCurrentPages();
},
-
- /**
- * @param {!{model: !{index: number}}} e
- * @private
- */
- onRemoveUrlTap_: function(e) {
- this.browserProxy_.removeStartupPage(e.model.index);
- },
});

Powered by Google App Engine
This is Rietveld 408576698