chrome/browser/resources/settings/on_startup_page/startup_url_entry.html - Issue 1876283002: MD Settings: On Startup, moving remove URL option under a dots menu.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/on_startup_page/startup_url_entry.html

Issue 1876283002: MD Settings: On Startup, moving remove URL option under a dots menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@edit_on_startup_cpp

Patch Set: Nits. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/on_startup_page/startup_url_entry.js » ('j') | chrome/browser/resources/settings/on_startup_page/startup_urls_page.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/html/util.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-drop down.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

	7 <link rel="import" href="chrome://md-settings/on_startup_page/startup_urls_page_ browser_proxy.html">

	8 <link rel="import" href="chrome://md-settings/settings_shared_css.html">

	9

	10 <dom-module id="settings-startup-url-entry">

	11 <template>

	12 <style include="settings-shared">

	13 .favicon-image {

	14 background-size: contain;

	15 background-repeat: no-repeat;

	16 height: 16px;

	17 width: 16px;

	18 }

	19

	20 .dropdown-content {

	21 background: white;

	22 box-shadow: 0 2px 6px grey;

	23 }

	24

	25 paper-item:hover {

	26 background-color: var(--settings-hover-color);

	27 }

	28 </style>

	29 <div class="list-item">
	Dan Beam 2016/04/12 18:23:26 to fix the grey lines, move class="list-item" onto to fix the grey lines, move class="list-item" onto the container element (i.e. outside of this file) and also apply the last hunk in this diff: https://codereview.chromium.org/1875413002/diff/1/chrome/browser/resources/se...
	30 <div class="favicon-image"

	31 style="background-image: [[getIconSet_(model.url)]]">

	32 </div>

	33 <div class="middle">

	34 <div class="text-elide">[[model.title]]</div>

	35 <div class="text-elide secondary">[[model.url]]</div>

	36 </div>

	37 <paper-icon-button id="dots" icon="more-vert" toggles

	38 active="{{menuOpened}}"></paper-icon-button>

	39 <template is="dom-if" if="[[menuOpened]]">

	40 <iron-dropdown vertical-align="top" horizontal-align="right"

	41 opened="{{menuOpened}}">

	42 <div class="dropdown-content">

	43 <paper-item id="remove" on-tap="onRemoveTap_">

	44 $i18n{onStartupRemove}

	45 </paper-item>

	46 </div>

	47 </iron-dropdown>

	48 </template>

	49 </div>

	50 </template>

	51 <script src="startup_url_entry.js"></script>

	52 </dom-module>

OLD	NEW