Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1876273002: Only compile ozone_platform_headless for headless.gn. (Closed)

Created:
4 years, 8 months ago by kylechar
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only compile ozone_platform_headless for headless.gn. Ensure that ozone_platform_headless is the only ozone platform compiled in the sample headless configuration. Other ozone platforms are included by default and aren't necessarily desired. BUG=none Committed: https://crrev.com/7dfdf188b6c9bfc4e208949a1be8af557c0264b0 Cr-Commit-Position: refs/heads/master@{#386672}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/args/headless.gn View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
kylechar
4 years, 8 months ago (2016-04-11 20:30:28 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1876273002/diff/1/build/args/headless.gn File build/args/headless.gn (right): https://codereview.chromium.org/1876273002/diff/1/build/args/headless.gn#newcode13 build/args/headless.gn:13: ozone_platform_headless = true why do we need both lines ...
4 years, 8 months ago (2016-04-11 21:47:07 UTC) #3
kylechar
https://codereview.chromium.org/1876273002/diff/1/build/args/headless.gn File build/args/headless.gn (right): https://codereview.chromium.org/1876273002/diff/1/build/args/headless.gn#newcode13 build/args/headless.gn:13: ozone_platform_headless = true On 2016/04/11 at 21:47:07, Dirk Pranke ...
4 years, 8 months ago (2016-04-11 22:34:43 UTC) #4
Dirk Pranke
gotcha, I figured it was something like that. lgtm.
4 years, 8 months ago (2016-04-11 22:55:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876273002/1
4 years, 8 months ago (2016-04-12 13:08:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 13:47:20 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 13:48:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7dfdf188b6c9bfc4e208949a1be8af557c0264b0
Cr-Commit-Position: refs/heads/master@{#386672}

Powered by Google App Engine
This is Rietveld 408576698