Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1876253002: Cleaning up FDE_CSS Classes. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleaning up FDE_CSS Classes. This Cl removes the IFDE_CSSAccelerator header and replaces the usage with the concrete class. The interfaces and methods in the CSSComputedStyle class are cleanedup to remove any unused methods. BUG=pdfium:468 Committed: https://pdfium.googlesource.com/pdfium/+/1fdde02d90963f774e7d1b6b0353d23aefe0a357

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -617 lines) Patch
M xfa/fde/css/fde_css.h View 1 2 5 chunks +24 lines, -171 lines 0 comments Download
M xfa/fde/css/fde_csscache.h View 1 chunk +5 lines, -3 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.h View 12 chunks +121 lines, -431 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.cpp View 3 chunks +4 lines, -10 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-11 19:36:39 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1876253002/diff/20001/xfa/fde/css/fde_css.h File xfa/fde/css/fde_css.h (right): https://codereview.chromium.org/1876253002/diff/20001/xfa/fde/css/fde_css.h#newcode29 xfa/fde/css/fde_css.h:29: class CFDE_CSSAccelerator; sort (all of these while we're ...
4 years, 8 months ago (2016-04-11 20:40:30 UTC) #3
dsinclair
https://codereview.chromium.org/1876253002/diff/20001/xfa/fde/css/fde_css.h File xfa/fde/css/fde_css.h (right): https://codereview.chromium.org/1876253002/diff/20001/xfa/fde/css/fde_css.h#newcode29 xfa/fde/css/fde_css.h:29: class CFDE_CSSAccelerator; On 2016/04/11 20:40:30, Tom Sepez wrote: > ...
4 years, 8 months ago (2016-04-11 20:43:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876253002/40001
4 years, 8 months ago (2016-04-11 20:43:46 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 21:09:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/1fdde02d90963f774e7d1b6b0353d23aefe0...

Powered by Google App Engine
This is Rietveld 408576698