Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1876243002: Exhaustive selection test.

Created:
4 years, 8 months ago by David Tseng
Modified:
4 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exhaustive selection test. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
dmazzoni
I have a fix for this: https://codereview.chromium.org/1942953003/ Let's take another look after that change lands.
4 years, 7 months ago (2016-05-02 21:58:19 UTC) #3
David Tseng
4 years, 7 months ago (2016-05-04 16:42:05 UTC) #4 
Unfortunately, this test still fails for the given snippet. We never get
back an event for offsets 1, 0.

On Mon, May 2, 2016 at 2:58 PM, <dmazzoni@chromium.org> wrote:

> I have a fix for this:
>
> https://codereview.chromium.org/1942953003/
>
> Let's take another look after that change lands.
>
>
> https://codereview.chromium.org/1876243002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698