Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1876223003: MIPS: Use max_d, min_d in LCodeGen::DoMathMinMax. (Closed)

Created:
4 years, 8 months ago by balazs.kilvady
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Use max_d, min_d in LCodeGen::DoMathMinMax. BUG= Committed: https://crrev.com/0f90237b970004514a1de54aa54dbd65ae46c2fd Cr-Commit-Position: refs/heads/master@{#35497}

Patch Set 1 #

Patch Set 2 : Rebased, added 32-bit and NaN checking. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -68 lines) Patch
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 chunks +10 lines, -34 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 chunks +10 lines, -34 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
balazs.kilvady
4 years, 8 months ago (2016-04-12 14:52:59 UTC) #2
akos.palfi.imgtec
Lgtm
4 years, 8 months ago (2016-04-14 14:26:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876223003/20001
4 years, 8 months ago (2016-04-14 14:28:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 14:48:34 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 14:50:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f90237b970004514a1de54aa54dbd65ae46c2fd
Cr-Commit-Position: refs/heads/master@{#35497}

Powered by Google App Engine
This is Rietveld 408576698