third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 1876123002: Absolute positioned child with percent should include containing block padding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1876123002: Absolute positioned child with percent should include containing block padding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add commit message Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-left-expected.txt ('k') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('j') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 4b9e74e5be2fa2d3b5f5857f549740976cb546cf..fc6010d490a1cde4e145a7bb40acedfd1ab8485b 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -186,7 +186,7 @@ static CSSValue* valueForPositionOffset(const ComputedStyle& style, CSSPropertyI

if (offset.hasPercent() && layoutObject && layoutObject->isBox() && layoutObject->isPositioned()) {

LayoutUnit containingBlockSize = (propertyID == CSSPropertyLeft || propertyID == CSSPropertyRight) ?

- toLayoutBox(layoutObject)->containingBlockLogicalWidthForContent() :

esprehn 2016/04/14 18:43:09 this is used in multiple other places in CSSValueM

Deokjin Kim 2016/04/20 13:42:09 On PS#7 this change is not needed anymore because

+ toLayoutBox(layoutObject)->containingBlockLogicalWidthForGetComputedStyle() :

toLayoutBox(layoutObject)->containingBlockLogicalHeightForGetComputedStyle();

return zoomAdjustedPixelValue(valueForLength(offset, containingBlockSize), style);

}