Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1876123002: Absolute positioned child with percent should include containing block padding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add commit message Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
index 4b9e74e5be2fa2d3b5f5857f549740976cb546cf..fc6010d490a1cde4e145a7bb40acedfd1ab8485b 100644
--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
@@ -186,7 +186,7 @@ static CSSValue* valueForPositionOffset(const ComputedStyle& style, CSSPropertyI
if (offset.hasPercent() && layoutObject && layoutObject->isBox() && layoutObject->isPositioned()) {
LayoutUnit containingBlockSize = (propertyID == CSSPropertyLeft || propertyID == CSSPropertyRight) ?
- toLayoutBox(layoutObject)->containingBlockLogicalWidthForContent() :
esprehn 2016/04/14 18:43:09 this is used in multiple other places in CSSValueM
Deokjin Kim 2016/04/20 13:42:09 On PS#7 this change is not needed anymore because
+ toLayoutBox(layoutObject)->containingBlockLogicalWidthForGetComputedStyle() :
toLayoutBox(layoutObject)->containingBlockLogicalHeightForGetComputedStyle();
return zoomAdjustedPixelValue(valueForLength(offset, containingBlockSize), style);
}

Powered by Google App Engine
This is Rietveld 408576698