Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1876103002:
Revert of [compiler] Make feedback vector cope with flag changes. (Closed)
|
Created:
4 years, 8 months ago by Michael Hablich Modified:
4 years, 8 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionRevert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ )
Reason for revert:
Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001
Original issue's description:
> [compiler] Make feedback vector cope with flag changes.
>
> This fixes corner cases where the layout of feedback vectors baked into
> the snapshot is different from the expected layout, depending on some
> runtime flags. We make sure the feedback vector is regenereated for
> functions that are not compiled. Flag changes of this kind are only
> allowed when code is not serialized.
>
> An alternative solution would be to not serialize the feedback vector
> for such cases in the first place. That solution however would have a
> higher overhead, as it would required the serializer to be able to
> recognize feedback vectors while generating a snapshot.
>
> R=mvstanton@chromium.org
> TEST=mjsunit/regress/regress-crbug-600995
> BUG=chromium:600995
> LOG=n
>
> Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c
> Cr-Commit-Position: refs/heads/master@{#35339}
TBR=mvstanton@chromium.org,mstarzinger@chromium.org
BUG=chromium:600995
LOG=N
NOTRY=true
Committed: https://crrev.com/78049e9c4837f053575d6c71e53ae12fec99f1aa
Cr-Commit-Position: refs/heads/master@{#35392}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Created Revert of [compiler] Make feedback vector cope with flag changes.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876103002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876103002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13464)
Description was changed from ========== Revert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ ) Reason for revert: Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001 Original issue's description: > [compiler] Make feedback vector cope with flag changes. > > This fixes corner cases where the layout of feedback vectors baked into > the snapshot is different from the expected layout, depending on some > runtime flags. We make sure the feedback vector is regenereated for > functions that are not compiled. Flag changes of this kind are only > allowed when code is not serialized. > > An alternative solution would be to not serialize the feedback vector > for such cases in the first place. That solution however would have a > higher overhead, as it would required the serializer to be able to > recognize feedback vectors while generating a snapshot. > > R=mvstanton@chromium.org > TEST=mjsunit/regress/regress-crbug-600995 > BUG=chromium:600995 > LOG=n > > Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c > Cr-Commit-Position: refs/heads/master@{#35339} TBR=mvstanton@chromium.org,mstarzinger@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:600995 ========== to ========== Revert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ ) Reason for revert: Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001 Original issue's description: > [compiler] Make feedback vector cope with flag changes. > > This fixes corner cases where the layout of feedback vectors baked into > the snapshot is different from the expected layout, depending on some > runtime flags. We make sure the feedback vector is regenereated for > functions that are not compiled. Flag changes of this kind are only > allowed when code is not serialized. > > An alternative solution would be to not serialize the feedback vector > for such cases in the first place. That solution however would have a > higher overhead, as it would required the serializer to be able to > recognize feedback vectors while generating a snapshot. > > R=mvstanton@chromium.org > TEST=mjsunit/regress/regress-crbug-600995 > BUG=chromium:600995 > LOG=n > > Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c > Cr-Commit-Position: refs/heads/master@{#35339} TBR=mvstanton@chromium.org,mstarzinger@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:600995 LOG=N NOTRY=true ==========
Description was changed from ========== Revert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ ) Reason for revert: Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001 Original issue's description: > [compiler] Make feedback vector cope with flag changes. > > This fixes corner cases where the layout of feedback vectors baked into > the snapshot is different from the expected layout, depending on some > runtime flags. We make sure the feedback vector is regenereated for > functions that are not compiled. Flag changes of this kind are only > allowed when code is not serialized. > > An alternative solution would be to not serialize the feedback vector > for such cases in the first place. That solution however would have a > higher overhead, as it would required the serializer to be able to > recognize feedback vectors while generating a snapshot. > > R=mvstanton@chromium.org > TEST=mjsunit/regress/regress-crbug-600995 > BUG=chromium:600995 > LOG=n > > Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c > Cr-Commit-Position: refs/heads/master@{#35339} TBR=mvstanton@chromium.org,mstarzinger@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:600995 LOG=N NOTRY=true ========== to ========== Revert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ ) Reason for revert: Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001 Original issue's description: > [compiler] Make feedback vector cope with flag changes. > > This fixes corner cases where the layout of feedback vectors baked into > the snapshot is different from the expected layout, depending on some > runtime flags. We make sure the feedback vector is regenereated for > functions that are not compiled. Flag changes of this kind are only > allowed when code is not serialized. > > An alternative solution would be to not serialize the feedback vector > for such cases in the first place. That solution however would have a > higher overhead, as it would required the serializer to be able to > recognize feedback vectors while generating a snapshot. > > R=mvstanton@chromium.org > TEST=mjsunit/regress/regress-crbug-600995 > BUG=chromium:600995 > LOG=n > > Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c > Cr-Commit-Position: refs/heads/master@{#35339} TBR=mvstanton@chromium.org,mstarzinger@chromium.org BUG=chromium:600995 LOG=N NOTRY=true ==========
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876103002/1
Message was sent while issue was closed.
Description was changed from ========== Revert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ ) Reason for revert: Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001 Original issue's description: > [compiler] Make feedback vector cope with flag changes. > > This fixes corner cases where the layout of feedback vectors baked into > the snapshot is different from the expected layout, depending on some > runtime flags. We make sure the feedback vector is regenereated for > functions that are not compiled. Flag changes of this kind are only > allowed when code is not serialized. > > An alternative solution would be to not serialize the feedback vector > for such cases in the first place. That solution however would have a > higher overhead, as it would required the serializer to be able to > recognize feedback vectors while generating a snapshot. > > R=mvstanton@chromium.org > TEST=mjsunit/regress/regress-crbug-600995 > BUG=chromium:600995 > LOG=n > > Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c > Cr-Commit-Position: refs/heads/master@{#35339} TBR=mvstanton@chromium.org,mstarzinger@chromium.org BUG=chromium:600995 LOG=N NOTRY=true ========== to ========== Revert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ ) Reason for revert: Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001 Original issue's description: > [compiler] Make feedback vector cope with flag changes. > > This fixes corner cases where the layout of feedback vectors baked into > the snapshot is different from the expected layout, depending on some > runtime flags. We make sure the feedback vector is regenereated for > functions that are not compiled. Flag changes of this kind are only > allowed when code is not serialized. > > An alternative solution would be to not serialize the feedback vector > for such cases in the first place. That solution however would have a > higher overhead, as it would required the serializer to be able to > recognize feedback vectors while generating a snapshot. > > R=mvstanton@chromium.org > TEST=mjsunit/regress/regress-crbug-600995 > BUG=chromium:600995 > LOG=n > > Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c > Cr-Commit-Position: refs/heads/master@{#35339} TBR=mvstanton@chromium.org,mstarzinger@chromium.org BUG=chromium:600995 LOG=N NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ ) Reason for revert: Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001 Original issue's description: > [compiler] Make feedback vector cope with flag changes. > > This fixes corner cases where the layout of feedback vectors baked into > the snapshot is different from the expected layout, depending on some > runtime flags. We make sure the feedback vector is regenereated for > functions that are not compiled. Flag changes of this kind are only > allowed when code is not serialized. > > An alternative solution would be to not serialize the feedback vector > for such cases in the first place. That solution however would have a > higher overhead, as it would required the serializer to be able to > recognize feedback vectors while generating a snapshot. > > R=mvstanton@chromium.org > TEST=mjsunit/regress/regress-crbug-600995 > BUG=chromium:600995 > LOG=n > > Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c > Cr-Commit-Position: refs/heads/master@{#35339} TBR=mvstanton@chromium.org,mstarzinger@chromium.org BUG=chromium:600995 LOG=N NOTRY=true ========== to ========== Revert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ ) Reason for revert: Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001 Original issue's description: > [compiler] Make feedback vector cope with flag changes. > > This fixes corner cases where the layout of feedback vectors baked into > the snapshot is different from the expected layout, depending on some > runtime flags. We make sure the feedback vector is regenereated for > functions that are not compiled. Flag changes of this kind are only > allowed when code is not serialized. > > An alternative solution would be to not serialize the feedback vector > for such cases in the first place. That solution however would have a > higher overhead, as it would required the serializer to be able to > recognize feedback vectors while generating a snapshot. > > R=mvstanton@chromium.org > TEST=mjsunit/regress/regress-crbug-600995 > BUG=chromium:600995 > LOG=n > > Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c > Cr-Commit-Position: refs/heads/master@{#35339} TBR=mvstanton@chromium.org,mstarzinger@chromium.org BUG=chromium:600995 LOG=N NOTRY=true Committed: https://crrev.com/78049e9c4837f053575d6c71e53ae12fec99f1aa Cr-Commit-Position: refs/heads/master@{#35392} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/78049e9c4837f053575d6c71e53ae12fec99f1aa Cr-Commit-Position: refs/heads/master@{#35392}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1876973002/ by hablich@chromium.org. The reason for reverting is: Did not fail on another roll including this CL .. . |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
