Issue 187603011: GraphicsLayer::removeAllChildren shouldn't be n^2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187603011: GraphicsLayer::removeAllChildren shouldn't be n^2 (Closed)

Created:
6 years, 9 months ago by abarth-chromium

Modified:
6 years, 9 months ago

Reviewers:
esprehn, ojan

CC:
blink-reviews, jamesr, krit, danakj, dsinclair, jbroman, blink-layers+watch_chromium.org, Rik, Stephen Chennney, pdr., rwlbuis, ojan, Ian Vollick

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

GraphicsLayer::removeAllChildren shouldn't be n^2 This CL changes GraphicsLayer::removeAllChildren to be linear in the number of children instead of n^2. Previously, we were removing the zero-th element of the vector in a loop, which causes a shift of all the elements of the vector. Now we walk the vector from the end, which means remove is constant cost. This code is called during a compositing update if anything changes about the GraphicsLayer's children. We didn't actually see this code on our profile because we're not actually changing the GraphicsLayer tree, but it seemed worth fixing. R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168598